Skip to content

chore(deps): bump tar from 0.4.44 to 0.4.45 in the cargo group across 1 directory#185

Merged
randygrok merged 4 commits intomainfrom
dependabot/cargo/cargo-82c2e2ce39
Mar 25, 2026
Merged

chore(deps): bump tar from 0.4.44 to 0.4.45 in the cargo group across 1 directory#185
randygrok merged 4 commits intomainfrom
dependabot/cargo/cargo-82c2e2ce39

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 20, 2026

Bumps the cargo group with 1 update in the / directory: tar.

Updates tar from 0.4.44 to 0.4.45

Commits
  • 096e3d1 Bump to 0.4.45 (#443)
  • 17b1fd8 archive: Prevent symlink-directory collision chmod attack (#442)
  • de1a587 archive: Unconditionally honor PAX size (#441)
  • 6071cbe ci: Consolidate workflows (#439)
  • ad1fde9 build-sys: Promote unused_code to an error
  • c8cb250 tests: Squash a warning
  • 638c495 ci: Add xtask infra + reverse dependency testing (#435)
  • 32a9bbb tests: Add RandomReader to exercise partial-read resilience (#436)
  • 9c5df0b Fix GNU long-name extension stream corruption on validation error (#434)
  • 88b1e3b Fix docs typo in header.rs (#431)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Bumps the cargo group with 1 update in the / directory: [tar](https://github.com/alexcrichton/tar-rs).


Updates `tar` from 0.4.44 to 0.4.45
- [Commits](alexcrichton/tar-rs@0.4.44...0.4.45)

---
updated-dependencies:
- dependency-name: tar
  dependency-version: 0.4.45
  dependency-type: indirect
  dependency-group: cargo
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Mar 20, 2026

Labels

The following labels could not be found: dependencies, rust. Please create them before Dependabot can add them to a pull request.

Please fix the above issues or remove invalid values from dependabot.yml.

@dependabot dependabot bot requested a review from a team as a code owner March 20, 2026 18:12
@claude
Copy link

claude bot commented Mar 25, 2026

Claude finished @dependabot[bot]'s task —— View job


Code Review Complete ✅

Reviewing this dependency update PR for:

  • Analyze changed files
  • Review tar security update details
  • Assess code quality and best practices
  • Check for potential issues
  • Evaluate security improvements
  • Provide final review feedback

📋 Review Summary

This PR combines two separate changes that should ideally be in separate commits:

  1. ✅ Dependency Update: tar crate 0.4.44 → 0.4.45
  2. ✅ CI Improvement: Exclude ev-tests from unit workflow

🔍 Detailed Analysis

Dependency Update (tar 0.4.44 → 0.4.45)

Security Improvements 🛡️:

  • Critical Fix: Prevents symlink-directory collision chmod attack (#442)
  • Data Integrity: Unconditionally honors PAX size (#441)

Code Quality:

  • ✅ Proper semantic versioning (patch release)
  • ✅ Cargo.lock properly updated with consistent dependencies
  • ✅ No breaking changes expected

Workflow Change (.github/workflows/unit.yml:38)

Change: Added - package(ev-tests) to test exclusion filter

Assessment:

  • Well-justified: ev-tests contains e2e tests that can hang under CI resource pressure
  • Proper separation: E2e tests already run in dedicated e2e workflow with 60min timeout
  • Performance improvement: Reduces unit test execution time and flakiness

🚨 Issues Found

Minor Process Issue:

  • These are logically separate changes that ideally should be in separate commits
  • The workflow change was added after the original dependency update
  • However, both changes are beneficial and well-implemented

🔒 Security Assessment

Excellent Security Update:

  • Fixes a security vulnerability in tar extraction
  • The symlink-chmod attack prevention is particularly important for any code that extracts tar files
  • No new security concerns introduced

📊 Performance Considerations

  • ✅ Dependency update should have no performance impact
  • ✅ Workflow change will improve CI performance by excluding slow e2e tests

🧪 Test Coverage

  • ✅ Unit tests properly scoped (excludes e2e tests)
  • ✅ E2e tests still run in dedicated workflow
  • ✅ No reduction in actual test coverage

✅ Recommendation

APPROVE - This is a beneficial update that:

  1. Fixes a security vulnerability in the tar crate
  2. Improves CI workflow efficiency
  3. Maintains proper test coverage separation

Both changes are well-implemented and improve the codebase.


@randygrok randygrok enabled auto-merge (squash) March 25, 2026 11:12
The ev-tests package contains e2e tests that start full nodes and can
hang under CI resource pressure. These tests already run in the
dedicated e2e workflow with a 60-minute timeout.
@randygrok randygrok merged commit a6ed7a9 into main Mar 25, 2026
16 checks passed
@randygrok randygrok deleted the dependabot/cargo/cargo-82c2e2ce39 branch March 25, 2026 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant