✨ app: add support for multi-chain asset recovery#970
✨ app: add support for multi-chain asset recovery#970dieguezguille wants to merge 13 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: 9be0067 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughAdds cross-chain asset discovery and execution, portfolio restructuring, new UI sheets for external/collateral/unsupported networks, cross-chain account client routing, multiple query helpers for deployed/wallet balances, i18n updates, and assorted UI/layout tweaks. Includes many small changesets for patch releases. Changes
Sequence DiagramsequenceDiagram
participant User
participant Bridge as Bridge Component
participant Portfolio as Portfolio Screen
participant QueryClient as Query Client
participant LiFi as LiFi API
participant Deployed as Deployed Check
User->>Portfolio: Open portfolio
Portfolio->>QueryClient: fetch markets, same-chain & wallet balances
QueryClient->>LiFi: request tokenBalances & walletBalances
LiFi-->>QueryClient: return balances per chain
QueryClient->>Deployed: check contract bytecode per chain
Deployed-->>Portfolio: deployed status
Portfolio->>User: render collateral + external assets grouped by chain
User->>Bridge: select external asset -> navigate with sender, sourceChain, sourceToken
Bridge->>Bridge: classify mode (isTransfer/isSwap/isRecovery)
alt isTransfer (same-chain)
Bridge->>Wallet: send native transaction
Wallet->>Network: broadcast tx
else cross-chain / recovery
Bridge->>AccountClient: request cross-chain client for targetChain
AccountClient->>CrossChainClient: build/sign UserOperation
CrossChainClient->>Network: submit UserOperation
Network-->>CrossChainClient: execution/result
CrossChainClient-->>Bridge: return composite id/result
end
Bridge->>User: show success/failure
sequenceDiagram
participant User
participant ExternalAssets as ExternalAssets Component
participant QueryClient as Query Client
participant Deployed as Deployed Check
participant Unsupported as UnsupportedNetworksSheet
User->>ExternalAssets: Tap non-collateral asset
ExternalAssets->>QueryClient: ensure deployedOptions(account, chainId) queries
QueryClient->>Deployed: return deployed/not-deployed
alt not supported or not deployed
ExternalAssets->>Unsupported: open UnsupportedNetworksSheet with formatted recovery message
Unsupported->>User: show contact support flow (Intercom)
else supported & deployed
ExternalAssets->>Bridge: navigate to Bridge with asset params
end
Estimated code review effort🎯 4 (Complex) | ⏱️ ~75 minutes 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
❌ 1 Tests Failed:
View the full list of 1 ❄️ flaky test(s)
To view more test analytics, go to the Prevent Tests Dashboard |
4868ef9 to
eb6d3a6
Compare
4bcfa86 to
c19bd5d
Compare
c19bd5d to
e79dd5b
Compare
e79dd5b to
aae3144
Compare
aae3144 to
5c6c745
Compare
ebb61b1 to
20f2565
Compare
20f2565 to
381d1b1
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 003024cc80
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d4a5dcfbdd
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0beea35502
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
2040427 to
089affc
Compare
closes #854 , closes #649, closes #747
Summary by CodeRabbit
New Features
Bug Fixes
Refactors
Localization