Default --since to latest GitHub Release's tag instead of publication date#166
Conversation
7063e1f to
04844ff
Compare
|
nice! if I understand, you're basically saying that we should use the git ref associated with the release, rather than the technical date the release is published. And that is because the author might update the git ref which will update the tag but not the "published" date. Is that right? And re: llm stuff, there's no formal policy in executablebooks. My 2 cents is that I care more about the thought and care a person put into the PR, regardless of what tools they use. I will tend to put less time into (or dismiss) PRs that are obviously not thoughtful (e.g. obvious AI slop, code that doesn't make sense in a pretty clear way, etc regardless of whether an LLM was used). Other than that I want people to use the tools they need to meet their goals in a sustainable way to them. |
Ah i wasnt considering a changing git ref for the same github release, but that is a thought as well hmmm. I was thinking that the git tag and git relesde date may be out of sync, and that it then better to relate to the git ref for comparison. For example, you push a git tag, then commit more to main, then a week later get the github release out referencing the tag. |
choldgraf
left a comment
There was a problem hiding this comment.
This looks good to me! I just have one question to confirm w/ @consideRatio :
Is there always a git tag for a release? If so then I think this is fine
At least for a non-draft release - yes! And we fetch the latest non-draft non-pre-release release - so we are good! |
|
Thank you for the swift review @choldgraf!! |
With #125 we started relating to the latest GitHub Release, and specifically its associated publication date. The motivation for this was described by @choldgraf as:
I was thinking it could be even better to relate to the GitHub Release's tag because a GitHub Release could be retroactively created for some older tag, and would then incorrectly indicate what is relevant to relate to. So, this is what this PR proposes.
By doing this, we also avoid an error message where the latest GitHub Release's publication date was tested by github-activity as a git reference before being treated as a date.
Before this PR
After this PR
AI disclaimer
I've used codex (GPT 5.5) as a tool for verification of my hypothesis of what was going on, and some code changes in this PR. Is there a policy about this within executablebooks to be aware about AI use?