Skip to content

✨ Add leaf div - #72

Closed
chrisjsewell wants to merge 1 commit into
masterfrom
leaf-block
Closed

chrisjsewell wants to merge 1 commit into
masterfrom
leaf-block

Conversation

@chrisjsewell

Copy link
Copy Markdown
Member

No description provided.

@codecov

codecov Bot commented Feb 24, 2023 •

Copy link
Copy Markdown

Codecov Report

Base: 92.84% // Head: 92.93% // Increases project coverage by +0.08% 🎉

Coverage data is based on head (6f62395) compared to base (bb67d10).
Patch coverage: 95.91% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #72      +/-   ##
==========================================
+ Coverage   92.84%   92.93%   +0.08%     
==========================================
  Files          30       31       +1     
  Lines        1748     1797      +49     
==========================================
+ Hits         1623     1670      +47     
- Misses        125      127       +2     
Flag Coverage Δ
pytests 92.93% <95.91%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mdit_py_plugins/leaf_directive.py 95.91% <95.91%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Alunderin

Copy link
Copy Markdown

It'd be great if this could be configured to use a custom validate and render function in the same way as the containers plugin.

@chrisjsewell

Copy link
Copy Markdown
Member Author

Closing this old draft of mine. It was an experiment, and it never got a spec, docs or a user.
The ::name content syntax it uses also conflicts with the ::name[label]{attrs} leaf form from the generic-directives proposal and remark-directive, which I would rather stay compatible with.
It also had some rendering issues: parse_content=False rendered a self-closing or unclosed <div>, and the body swallowed the headings, fences and lists that followed it.
If there is real demand for a leaf directive, please open an issue describing the use case and we can design it properly from there.
Thanks to Alunderin for the validate / render suggestion; any new version should support those, as container_plugin does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants