Skip to content

[pyrefly] Share invalidation queueing lifecycle - #4384

Draft
lyydsheep wants to merge 1 commit into
facebook:mainfrom
lyydsheep:codex/issue-4300-share-invalidation
Draft

[pyrefly] Share invalidation queueing lifecycle#4384
lyydsheep wants to merge 1 commit into
facebook:mainfrom
lyydsheep:codex/issue-4300-share-invalidation

Conversation

@lyydsheep

Copy link
Copy Markdown
Contributor

Fixes #4300

Summary

  • Consolidate the duplicated asynchronous invalidation transaction lifecycle into one private queueing helper.
  • Preserve ordinary invalidation telemetry, streaming, test-only pre-commit pause, cancellation, commit order, and completion behavior.
  • Preserve configuration invalidation completion conditions and keep it independent of the ordinary invalidation pause.
  • The local .scratch planning files are intentionally not included in this PR.

Validation

  • cargo test -p pyrefly lsp_interaction::configuration — 22 passed
  • cargo test -p pyrefly lsp_interaction::diagnostic — 37 passed, 1 existing ignored
  • cargo test -p pyrefly lsp_interaction::file_watcher — 3 passed
  • cargo test -p pyrefly lsp_interaction::cross_file_invalidation_project_mode — 3 passed
  • cargo test -p pyrefly lsp_interaction::did_change — 3 passed
  • python3 test.py --no-test --no-tensor-shapes --no-conformance --no-jsonschema — passed; one pre-existing Clippy warning in crates/pyrefly_config/src/error_kind.rs

Consolidate the duplicated asynchronous invalidation transaction flow while keeping ordinary and configuration-specific completion behavior in their callers.
@meta-cla

meta-cla Bot commented Aug 1, 2026

Copy link
Copy Markdown

Hi @lyydsheep!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@github-actions github-actions Bot added the size/s label Aug 1, 2026
@meta-cla meta-cla Bot added the cla signed label Aug 1, 2026
@meta-cla

meta-cla Bot commented Aug 1, 2026

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

share invalidate and invalidate_config_and_validate_in_memory

1 participant