fix datetimes and dates are not substitutable #4342 - #4466
Open
asukaminato0721 wants to merge 1 commit into
Open
fix datetimes and dates are not substitutable #4342#4466asukaminato0721 wants to merge 1 commit into
asukaminato0721 wants to merge 1 commit into
Conversation
Contributor
|
This pull request has been imported. If you are a Meta employee, you can view this in D115051490. (Because this pull request was imported automatically, there will not be any future comments.) |
|
Diff from mypy_primer, showing the effect of this PR on open source code: core (https://github.com/home-assistant/core)
+ ERROR homeassistant/components/habitica/calendar.py:251:28-73: `<` is not supported between `datetime` and `date` [unsupported-operation]
+ ERROR homeassistant/components/lamarzocco/calendar.py:101:20-46: `<` is not supported between `date` and `datetime` [unsupported-operation]
+ ERROR homeassistant/components/lamarzocco/calendar.py:103:20-46: `>` is not supported between `date` and `datetime` [unsupported-operation]
+ ERROR homeassistant/components/radarr/coordinator.py:178:20-47: `>=` is not supported between `datetime` and `date` [unsupported-operation]
+ ERROR homeassistant/components/radarr/coordinator.py:194:16-69: `>=` is not supported between `datetime` and `date` [unsupported-operation]
+ ERROR homeassistant/components/sonarr/calendar.py:68:51-66: `>` is not supported between `date` and `datetime` [unsupported-operation]
+ ERROR homeassistant/components/workday/calendar.py:95:43-77: `>=` is not supported between `datetime` and `date` [unsupported-operation]
+ ERROR homeassistant/components/workday/calendar.py:105:16-69: `<=` is not supported between `date` and `datetime` [unsupported-operation]
+ ERROR homeassistant/components/workday/calendar.py:105:16-69: `<=` is not supported between `datetime` and `date` [unsupported-operation]
|
Contributor
|
are the added primer errors false positives? |
Collaborator
Author
checked the code, https://github.com/home-assistant/core/blob/c263da982a0b98b0f1540fda08f298de56bbc44b/homeassistant/components/calendar/__init__.py#L373 the declare use sooo, kind of. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4342
Ordered date/datetime comparisons now report unsupported-operation in either operand order.
Equality and same-type ordering remain valid.
Test Plan
add test