Fix non-localized company suffixes in CH and it locales#3271
Open
huerlisi wants to merge 1 commit into
Open
Conversation
`Faker::Company.name` produced anglophone legal forms that do not exist in these locales, e.g. "Klimczak LLC" (de-CH), "Adam LLC" (fr-CH) and "Russo Group" (it). - de-CH: drop the English `LLC` and `Inc.` suffixes. - fr-CH: drop `LLC`/`Inc.` and add the Swiss-French forms `SA` and `Sàrl`. - it: replace English `Group` with the Italian `Gruppo`. Add tests asserting the English forms are gone (and the localized forms present) so the lists don't regress. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Author
|
I used Claude Code to create this MR and it included very specific unit tests. I don't see too much value in those but they don't hurt. Should I drop them, or what is best practice in this repo around unit tests? |
Author
|
Related but not directly part of this MR: I understand that the project has a "freeze" on new locales. For Switzerland there's currently DE and FR locales available, but no for the IT speaking part. As Swiss that feels as kind of a bug:-) Would you accept a contribution that introduces an |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation / Background
Faker::Company.nameproduced anglophone legal forms that do not exist inthese locales:
LLCandInc.are US forms and are not used in Switzerland;GroupisEnglish. This Pull Request fixes the company
suffixlists:LLCandInc.suffixes.LLC/Inc.and add the Swiss-French formsSAandSàrl.Groupwith the ItalianGruppo.Additional information
Output after the change:
Tests assert the English forms are gone (and the localized forms present)
so the lists don't regress.
Checklist