Merged
Conversation
- プロジェクト単位でコメント一覧を取得するSDKメソッドを追加 - フィルタパラメータ: status, external_status, tags, issue_category_id
tags/status/externalStatus → taskTags/taskStatus/taskExternalStatus fastlabel/fastlabel-application#10927
…entThreadExportVOに更新
PRレビュー指摘対応: if offset: / if limit: だと値が0のときFalsyとして無視されるため、 is not None チェックに変更した
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
サマリ
概要、背景
fastlabel/fastlabel-application#10863 対応のSDK実装。プロジェクト単位でコメント一覧を取得できる
get_project_commentsメソッドを追加。(不具合の場合のみ) 発生原因
対応内容
やったこと
get_project_commentsメソッドを追加API側の変更(fastlabel-application PR #10927)に対応。
taskIdを省略してプロジェクト全体のコメントを取得する。やれていないこと、妥協点
UI/UX
before
after
テスト
変更の意図に沿った基本動作が確認できている
get_project_comments(project="slug")でコメント一覧が取得できる関連する既存機能にデグレがないことを確認
get_task_commentsに変更がないことエッジケースや例外パターンの動作を確認
関連リンク
補足