Cover Express not-found delegation - #983
Draft
aryansk wants to merge 1 commit into
Draft
Conversation
Fixes fedify-dev#857 Assisted-by: Codex:gpt-5
✅ Deploy Preview for fedify-json-schema canceled.
|
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@fedify/expressregression coverage for not-found delegation.next()is invoked when Fedify callsonNotFound.Fixes #857
Validation
node --experimental-transform-types --test packages/express/src/index.test.tsdeno fmt --check packages/express/src/index.test.tsdeno lint --no-config packages/express/src/index.test.tsThe repository-wide
mise run check-each expresswas not completed in this checkout because the pinned clean-checkout bootstrap attempted uncached monorepo downloads; the focused regression, formatting, and lint checks pass.AI disclosure: OpenAI Codex (GPT-5) assisted with the implementation and validation of this issue-scoped test.