Skip to content

Cover Express not-found delegation - #983

Draft
aryansk wants to merge 1 commit into
fedify-dev:mainfrom
aryansk:codex/issue-857-express-delegation
Draft

Cover Express not-found delegation#983
aryansk wants to merge 1 commit into
fedify-dev:mainfrom
aryansk:codex/issue-857-express-delegation

Conversation

@aryansk

@aryansk aryansk commented Aug 6, 2026

Copy link
Copy Markdown

Summary

  • Add focused @fedify/express regression coverage for not-found delegation.
  • Assert Express next() is invoked when Fedify calls onNotFound.

Fixes #857

Validation

  • node --experimental-transform-types --test packages/express/src/index.test.ts
  • deno fmt --check packages/express/src/index.test.ts
  • deno lint --no-config packages/express/src/index.test.ts

The repository-wide mise run check-each express was not completed in this checkout because the pinned clean-checkout bootstrap attempted uncached monorepo downloads; the focused regression, formatting, and lint checks pass.

AI disclosure: OpenAI Codex (GPT-5) assisted with the implementation and validation of this issue-scoped test.

Fixes fedify-dev#857

Assisted-by: Codex:gpt-5
@netlify

netlify Bot commented Aug 6, 2026

Copy link
Copy Markdown

Deploy Preview for fedify-json-schema canceled.

Name Link
🔨 Latest commit 10f7085
🔍 Latest deploy log https://app.netlify.com/projects/fedify-json-schema/deploys/6a749c7febbd010008fe90ad

@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: d9a16cad-e714-4198-91fb-d6c76957ec1d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Test not-found delegation in @fedify/express

1 participant