[PAY-7260] add support for disputes endpoints#126
Merged
Conversation
Gonzalo9823
reviewed
May 19, 2026
| from fintoc.mixins import ManagerMixin | ||
|
|
||
|
|
||
| # pylint: disable=duplicate-code |
Contributor
Author
There was a problem hiding this comment.
Es porque el pylint puede detectar bloques de código muy parecidos entre diferentes archivos. Es algo que usamos en todos los managers
Gonzalo9823
reviewed
May 19, 2026
|
|
||
| # pylint: disable=duplicate-code | ||
| class DisputesManager(ManagerMixin): | ||
|
|
Gonzalo9823
reviewed
May 19, 2026
| from .accounts_manager import AccountsManager | ||
| from .charges_manager import ChargesManager | ||
| from .checkout_sessions_manager import CheckoutSessionsManager | ||
| from .dispute_documents_manager import DisputeDocumentsManager |
Contributor
There was a problem hiding this comment.
Porque necesita su propio Manager los Documents?
Contributor
Author
There was a problem hiding this comment.
Lo separé por dos razones:
- Sigue el patrón de
accounts.movements: recursos anidados en la API (/v1/disputes/:id/documents) tienen su propio manager en el SDK. _createdelManagerMixinusaself.__class__.resourcepara decidir qué clase instanciar. Si pongocreate_documentenDisputesManager(donderesource = "dispute"), tendría que bypassear_createy llamar aresource_createa mano conklass=DisputeDocument.
Además deja la puerta abierta a agregar list/get/delete de documentos sin tener que refactorizar.
Gonzalo9823
reviewed
May 19, 2026
|
|
||
|
|
||
| class Dispute(ResourceMixin): | ||
|
|
Gonzalo9823
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add support for newly created
/v1/disputesendpointsRequirements
None.
Additional changes
None.