fix: v2 to v1 downgrade failing with CPU error - #10889
Open
IzaakGough wants to merge 7 commits into
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates inferDetailsFromExisting in src/deploy/functions/prepare.ts to only inherit infrastructure fields (availableMemoryMb, cpu, and timeoutSeconds) when the platform is unchanged. This prevents validation errors (such as setting CPU on GCF gen 1) when downgrading from gcfv2 to gcfv1, allowing the correct downgrade error to be raised. Unit tests have been added in src/deploy/functions/prepare.spec.ts to cover these scenarios. There are no review comments, and the changes look solid.
IzaakGough
marked this pull request as ready for review
August 6, 2026 10:36
Memory and timeout are valid on both generations, and the platform-equality guard also skipped them for gcfv2 vs run, which is a legal update. Gate only cpu, and reject a gcfv2-to-gcfv1 downgrade in validation so the error appears before the source is uploaded rather than in the release plan.
Skipping cpu inheritance for gcfv1 removed the only thing that stopped a deploy from trying to update an existing `run` endpoint into a gcfv1 function, which then failed with an opaque API error mid-deploy. Share one predicate between validation and the release planner so the two checks cannot drift, and cover both platforms.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5461
Redeploying an existing v2 function as v1 failed with a confusing "Cannot set CPU on ... because they are GCF gen 1" error.
inferDetailsFromExistingwas copying v2-only infrastructure fields (cpu,availableMemoryMb,timeoutSeconds) from the deployed function onto the new v1 endpoint, which then tripped CPU validation and hid the real error.These fields are now only inherited when the platform is unchanged, so a v2 to v1 change surfaces the accurate "cannot be downgraded" error instead.