Ignore missing StorageListResult swig#1420
Merged
AustinBenoit merged 1 commit intomainfrom Mar 28, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the SWIG interface for the storage module to ignore List methods and the StorageListResult class, as they are not yet wrapped. A review comment suggests adding a TODO to track the implementation of these methods as an improvement for technical debt management.
| %ignore firebase::storage::StorageReference::GetBytes; | ||
| %ignore firebase::storage::StorageReference::PutBytes; | ||
| %ignore firebase::storage::StorageReference::PutFile; | ||
| // Ignore List methods and StorageListResult since StorageListResult is not wrapped yet. |
Contributor
There was a problem hiding this comment.
To make it clear that this is a temporary workaround and should be addressed in the future, it's good practice to add a TODO comment. This helps in tracking technical debt and makes it easier for developers to find and fix it later.
// TODO: Wrap StorageListResult and expose List methods.
AustinBenoit
added
the
tests-requested: quick
github-actions
bot
added
tests: in-progress
❌ Integration test FAILEDRequested by @firebase-workflow-trigger[bot] on commit 1197834
|
a-maurice
approved these changes
Mar 27, 2026
firebase-workflow-trigger
bot
removed
the
tests: in-progress
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Ignore missing StorageListResult swig
Testing
Run build
Type of Change
Place an
xthe applicable box: