Change setPersistenceEnabled to async function #18014
Open
+2
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request updates the
setPersistenceEnabledmethod in theMethodChannelDatabaseclass to be asynchronous, ensuring that the persistence setting is fully applied before continuing. This change improves the reliability and consistency of enabling or disabling persistence.setPersistenceEnabledinMethodChannelDatabasefrom a synchronousvoidmethod to an asynchronousFuture<void>method, and now properly awaits the underlying platform call.In Android, when application reloads calling setPersistenceEnabled in the main function it causes a error saying it should called only once and before any reference, and there's no way to catch that error because it is a synchronous method calling an async method which throws the error.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?