Skip to content

fix(fdc): remove unused logs #18197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lyokone merged 1 commit into from
Apr 16, 2026
+0 −14
Merged

fix(fdc): remove unused logs #18197

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions packages/firebase_data_connect/firebase_data_connect/lib/src/core/ref.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,7 +342,6 @@ class QueryRef<Data, Variables> extends OperationRef<Data, Variables> {
_serverStreamSubscription?.cancel();
_serverStreamSubscription = null;
_serverStream = null;
log("QueryRef $operationId: All subscribers cancelled. Unsubscribed from server stream.");
}

Stream<QueryResult<Data, Variables>> subscribe() {
Expand Down Expand Up @@ -373,7 +372,6 @@ class QueryRef<Data, Variables> extends OperationRef<Data, Variables> {

void _streamFromServer() async {
bool shouldRetry = await _shouldRetry();
log("QueryRef $operationId _streamFromServer loop started.");
try {
_serverStream = _transport.invokeStreamQuery<Data, Variables>(
operationId,
Expand All @@ -386,7 +384,6 @@ class QueryRef<Data, Variables> extends OperationRef<Data, Variables> {

_serverStreamSubscription = _serverStream!.listen(
(serverResponse) async {
log("QueryRef $operationId _streamFromServer loop received snapshot.");
if (dataConnect.cacheManager != null) {
try {
await dataConnect.cacheManager!
Expand Down Expand Up @@ -432,8 +429,6 @@ class QueryRef<Data, Variables> extends OperationRef<Data, Variables> {
void publishResultToStream(QueryResult<Data, Variables> result) {
if (_streamController != null) {
_streamController?.add(result);
} else {
log("QueryRef $operationId _streamFromServer loop _streamController is null");
}
}

Expand Down
9 changes: 0 additions & 9 deletions ...ages/firebase_data_connect/firebase_data_connect/lib/src/network/websocket_transport.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,6 @@ class WebSocketTransport implements DataConnectTransport {
if (_channel == null) return;
final encoded = jsonEncode(json);
if (encoded.isNotEmpty) {
developer.log("Sending stream message \n $encoded");
_channel!.sink.add(encoded);
}
}
Expand Down Expand Up @@ -229,7 +228,6 @@ class WebSocketTransport implements DataConnectTransport {
} else {
bodyString = message as String;
}
developer.log("Received stream response \n $bodyString");

final bodyJson = jsonDecode(bodyString) as Map<String, dynamic>;
final response = StreamResponse.fromJson(bodyJson);
Expand Down Expand Up @@ -309,8 +307,6 @@ class WebSocketTransport implements DataConnectTransport {
Timer? _reconnectTimer;

void _scheduleReconnect() {
developer.log(
'${DateTime.now()} _scheduleReconnect $_reconnectAttempts $_isReconnecting $_isExpectedDisconnect');
if (_isReconnecting || _isExpectedDisconnect) return;
_isReconnecting = true;

Expand All @@ -323,13 +319,9 @@ class WebSocketTransport implements DataConnectTransport {
final delay = min(
_initialReconnectDelayMs * pow(2, _reconnectAttempts).toInt(),
_maxReconnectDelayMs);
var startTime = DateTime.now();
developer.log('$startTime scheduling _performReconnect in $delay ms');

_reconnectTimer?.cancel();
_reconnectTimer = Timer(Duration(milliseconds: delay), () async {
developer.log(
'${DateTime.now()} calling delayed _performReconnect scheduled at $startTime');
_performReconnect();
});
}
Expand Down Expand Up @@ -443,7 +435,6 @@ class WebSocketTransport implements DataConnectTransport {

void _onDone() {
if (_channel == null) return;
developer.log('WebSocket connection closed.');
_channel = null;
_isReconnecting = false;
if (!_isExpectedDisconnect) {
Expand Down
Loading