Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ dev_dependencies:
# activated in the `analysis_options.yaml` file located at the root of your
# package. See that file for information about deactivating specific lint
# rules and activating additional ones.
flutter_lints: ^4.0.0
flutter_lints: ^6.0.0

# For information on the generic Dart part of this file, see the
# following page: https://dart.dev/tools/pub/pubspec
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ class AudioOutput {
return null;
}
// Play audio stream
handle = await SoLoud.instance.play(myStream);
handle = SoLoud.instance.play(myStream);
return stream = myStream;
}

Expand Down
8 changes: 4 additions & 4 deletions packages/firebase_ai/firebase_ai/example/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ dependencies:
# The following adds the Cupertino Icons font to your application.
# Use with the CupertinoIcons class for iOS style icons.

camera: ^0.11.2+1
camera: ^0.12.0+1
camera_macos: ^0.0.9
cupertino_icons: ^1.0.6
firebase_ai: ^3.11.0
Expand All @@ -30,16 +30,16 @@ dependencies:
flutter:
sdk: flutter
flutter_animate: ^4.5.2
flutter_markdown: ^0.6.20
flutter_soloud: ^3.1.6
flutter_markdown: ^0.7.7+1
flutter_soloud: ^4.0.2
image: ^4.5.4
image_picker: ^1.1.2
path_provider: ^2.1.5
record: ^6.2.0
waveform_flutter: ^1.2.0

dev_dependencies:
flutter_lints: ^4.0.0
flutter_lints: ^6.0.0
flutter_test:
sdk: flutter

Expand Down
2 changes: 1 addition & 1 deletion packages/firebase_ai/firebase_ai/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ dependencies:
web_socket_channel: ^3.0.1

dev_dependencies:
flutter_lints: ^4.0.0
flutter_lints: ^6.0.0
flutter_test:
sdk: flutter
matcher: ^0.12.16
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ class _InstallationsCardState extends State<InstallationsCard> {
String id = 'None';
String authToken = 'None';

init() async {
Future<void> init() async {
await getId();
await getAuthToken();
}
Expand Down Expand Up @@ -101,7 +101,7 @@ class _InstallationsCardState extends State<InstallationsCard> {
}
}

Future<void> getAuthToken([forceRefresh = false]) async {
Future<void> getAuthToken([bool forceRefresh = false]) async {
try {
final token = await FirebaseInstallations.instance.getToken(forceRefresh);
setState(() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ dependencies:
sdk: flutter

dev_dependencies:
flutter_lints: ^4.0.0
flutter_lints: ^6.0.0

flutter:
uses-material-design: true
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,4 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

library firebase_app_installations_platform_interface;

export 'src/platform_interface/firebase_app_installations_platform_interface.dart';
Original file line number Diff line number Diff line change
Expand Up @@ -21,4 +21,4 @@ dev_dependencies:
firebase_core_platform_interface: ^6.0.3
flutter_test:
sdk: flutter
flutter_lints: ^4.0.0
flutter_lints: ^6.0.0
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
// found in the LICENSE file.

@JS('firebase_installations')
library firebase_interop.installations;
library;

import 'dart:js_interop';

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ dev_dependencies:
firebase_core_platform_interface: ^6.0.3
flutter_test:
sdk: flutter
flutter_lints: ^4.0.0
flutter_lints: ^6.0.0

flutter:
plugin:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@ let package = Package(
.process("Resources"),
],
cSettings: [
.headerSearchPath("include/firebase_auth/Private"),
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was an unrelated fix, but it did improve test pass rate! @cynthiajoan

See below, too!

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did notice this problem, and I was wondering if other packages have the same issue, haven't checked. @Lyokone mentioned he's going to check that.

.headerSearchPath("include/firebase_auth/Public"),
.headerSearchPath("include/Private"),
.headerSearchPath("include/Public"),
.define("LIBRARY_VERSION", to: "\"\(library_version)\""),
.define("LIBRARY_NAME", to: "\"flutter-fire-auth\""),
]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@ let package = Package(
.process("Resources"),
],
cSettings: [
.headerSearchPath("include/firebase_auth/Private"),
.headerSearchPath("include/firebase_auth/Public"),
.headerSearchPath("include/Private"),
.headerSearchPath("include/Public"),
.define("LIBRARY_VERSION", to: "\"\(library_version)\""),
.define("LIBRARY_NAME", to: "\"flutter-fire-auth\""),
]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,7 @@ class _DataConnectWidgetState extends State<DataConnectWidget> {
]));
}

_showError(String message) {
void _showError(String message) {
showDialog<void>(
context: context,
builder: (context) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ dev_dependencies:
flutter_test:
sdk: flutter

flutter_lints: ^4.0.0
flutter_lints: ^6.0.0
integration_test:
sdk: flutter

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ dev_dependencies:
build_runner: ^2.4.12
firebase_app_check_platform_interface: ^0.3.0
firebase_auth_platform_interface: ^8.1.9
flutter_lints: ^4.0.0
flutter_lints: ^6.0.0
flutter_test:
sdk: flutter
mockito: ^5.0.0
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ class DatabaseReference extends Query<database_interop.ReferenceJsImpl> {
///
/// This method returns [ThenableReference], [DatabaseReference]
/// with a [Future] property.
ThenableReference push([value]) => ThenableReference.fromJsObject(
ThenableReference push([Object? value]) => ThenableReference.fromJsObject(
database_interop.push(jsObject, value?.jsify()));

/// Removes data from actual database location.
Expand All @@ -148,8 +148,8 @@ class DatabaseReference extends Query<database_interop.ReferenceJsImpl> {
/// Sets a priority for data at actual database location.
///
/// The [priority] must be a [String], [num] or `null`, or the error is thrown.
Future setPriority(priority) =>
database_interop.setPriority(jsObject, priority).toDart;
Future setPriority(Object? priority) =>
database_interop.setPriority(jsObject, priority?.jsify()).toDart;

/// Sets data [newVal] at actual database location with provided priority
/// [newPriority].
Expand All @@ -159,9 +159,10 @@ class DatabaseReference extends Query<database_interop.ReferenceJsImpl> {
/// The [newVal] must be a Dart basic type or the error is thrown.
/// The [newPriority] must be a [String], [num] or `null`, or the error
/// is thrown.
Future setWithPriority(Object? newVal, newPriority) => database_interop
.setWithPriority(jsObject, newVal?.jsify(), newPriority)
.toDart;
Future setWithPriority(Object? newVal, Object? newPriority) =>
database_interop
.setWithPriority(jsObject, newVal?.jsify(), newPriority?.jsify())
.toDart;

/// Atomically updates data at actual database location.
///
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ dev_dependencies:
firebase_core_platform_interface: ^6.0.3
flutter_test:
sdk: flutter
flutter_lints: ^4.0.0
flutter_lints: ^6.0.0


flutter:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -98,10 +98,10 @@ void showFlutterNotification(RemoteMessage message) {
AndroidNotification? android = message.notification?.android;
if (notification != null && android != null && !kIsWeb) {
flutterLocalNotificationsPlugin.show(
notification.hashCode,
notification.title,
notification.body,
NotificationDetails(
id: notification.hashCode,
title: notification.title,
body: notification.body,
notificationDetails: NotificationDetails(
android: AndroidNotificationDetails(
channel.id,
channel.name,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ dependencies:
firebase_messaging: ^16.2.0
flutter:
sdk: flutter
flutter_local_notifications: ^17.2.1
flutter_local_notifications: ^21.0.0
http: ^1.0.0

flutter:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ class _MyAppState extends State<MyApp> {
FirebaseCustomModel? model;

/// Initially get the lcoal model if found, and asynchronously get the latest one in background.
initWithLocalModel() async {
Future<void> initWithLocalModel() async {
final newModel = await FirebaseModelDownloader.instance.getModel(
kModelName, FirebaseModelDownloadType.localModelUpdateInBackground);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ dependencies:
firebase_ml_model_downloader: ^0.4.2

dev_dependencies:
flutter_lints: ^4.0.0
flutter_lints: ^6.0.0

flutter:
uses-material-design: true
Loading