Copy column contents in getRawSamplesTableBuilderFromExisting for consistency#6168
Merged
Merged
Conversation
…sistency. The other getRawXYZBuilderWithExistingContents functions do the same; the samples version is only called in places where we then overwrite the original table so it didn't really make a difference, but let's be consistent with the other tables and actually make it so that if you push to the builder columns, the original table is unaffected.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6168 +/- ##
=======================================
Coverage 83.54% 83.55%
=======================================
Files 343 343
Lines 36858 36859 +1
Branches 10346 10357 +11
=======================================
+ Hits 30793 30796 +3
+ Misses 5637 5635 -2
Partials 428 428 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
canova
approved these changes
Jul 13, 2026
mstange
added a commit
that referenced
this pull request
Jul 13, 2026
<!-- profiler-preview-links:start --> [Main](https://main--perf-html.netlify.app/) | [Deploy preview](https://deploy-preview-6174--perf-html.netlify.app/) <!-- profiler-preview-links:end --> The auto-rebase of #6151 over #6168 caused a typecheck failure and auto-merge merged anyway. I've now added the "typecheck (ubuntu-latest)" task to the required passing tasks in the branch protection rules so this shouldn't happen again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main | Deploy preview
The other getRawXYZBuilderWithExistingContents functions do the same; the samples version is only called in places where we then overwrite the original table so it didn't really make a difference, but let's be consistent with the other tables and actually make it so that if you push to the builder columns, the original table is unaffected.