Skip to content

Copy column contents in getRawSamplesTableBuilderFromExisting for consistency#6168

Merged
mstange merged 2 commits into
firefox-devtools:mainfrom
mstange:push-rrqmxymomzwy
Jul 13, 2026
Merged

Copy column contents in getRawSamplesTableBuilderFromExisting for consistency#6168
mstange merged 2 commits into
firefox-devtools:mainfrom
mstange:push-rrqmxymomzwy

Conversation

@mstange

@mstange mstange commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Main | Deploy preview

The other getRawXYZBuilderWithExistingContents functions do the same; the samples version is only called in places where we then overwrite the original table so it didn't really make a difference, but let's be consistent with the other tables and actually make it so that if you push to the builder columns, the original table is unaffected.

…sistency.

The other getRawXYZBuilderWithExistingContents functions do the same;
the samples version is only called in places where we then overwrite
the original table so it didn't really make a difference, but let's
be consistent with the other tables and actually make it so that if
you push to the builder columns, the original table is unaffected.
@mstange mstange requested a review from canova July 10, 2026 23:13
@codecov

codecov Bot commented Jul 10, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 70.58824% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.55%. Comparing base (667e250) to head (6963f9e).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
src/profile-logic/data-structures.ts 70.58% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6168   +/-   ##
=======================================
  Coverage   83.54%   83.55%           
=======================================
  Files         343      343           
  Lines       36858    36859    +1     
  Branches    10346    10357   +11     
=======================================
+ Hits        30793    30796    +3     
+ Misses       5637     5635    -2     
  Partials      428      428           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mstange mstange enabled auto-merge July 13, 2026 14:25
@mstange mstange merged commit dd88555 into firefox-devtools:main Jul 13, 2026
21 checks passed
mstange added a commit that referenced this pull request Jul 13, 2026
<!-- profiler-preview-links:start -->
[Main](https://main--perf-html.netlify.app/) | [Deploy
preview](https://deploy-preview-6174--perf-html.netlify.app/)
<!-- profiler-preview-links:end -->

The auto-rebase of #6151 over #6168 caused a typecheck failure and
auto-merge merged anyway. I've now added the "typecheck (ubuntu-latest)"
task to the required passing tasks in the branch protection rules so
this shouldn't happen again.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants