Open
Conversation
fivetran-jamie
commented
Mar 4, 2026
|
|
||
| select count(distinct conversation_id) as stg_count | ||
| from {{ target.schema }}_intercom_dev.stg_intercom__conversation_history | ||
| where coalesce(_fivetran_active, true) |
Contributor
Author
There was a problem hiding this comment.
Since this filter is incorporated into the staging model
fivetran-jamie
commented
Mar 4, 2026
|
|
||
| select * | ||
| from final | ||
| where coalesce(_fivetran_active, true) No newline at end of file |
Contributor
Author
There was a problem hiding this comment.
Moved the filter from the end model to here
fivetran-jamie
commented
Mar 4, 2026
|
|
||
| select * | ||
| from final | ||
| where coalesce(_fivetran_active, true) No newline at end of file |
Contributor
Author
There was a problem hiding this comment.
Aligning with other tag_history models (example)
fivetran-jamie
commented
Mar 4, 2026
|
|
||
| select * | ||
| from final | ||
| where coalesce(_fivetran_active, true) No newline at end of file |
Contributor
Author
There was a problem hiding this comment.
This model isn't actually used downstream anywhere. Adding filter for consistency
fivetran-jamie
commented
Mar 4, 2026
| select * | ||
| from final No newline at end of file | ||
| from final | ||
| where coalesce(_fivetran_active, true) No newline at end of file |
Contributor
Author
There was a problem hiding this comment.
Moved the filter from downstream model to here
fivetran-jamie
commented
Mar 4, 2026
|
|
||
| select * | ||
| from final | ||
| where coalesce(_fivetran_active, true) No newline at end of file |
Contributor
Author
There was a problem hiding this comment.
Aligning with other tag_history models (example)
fivetran-savage
added
the
status:stale
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Overview
Package version introduced in this PR:
This PR addresses the following Issue/Feature(s):
Summary of changes:
_fivetran_activefilter to staging models when possible. The only_historytable where I did not do this wasconversation_part_history, as it maybe seems useful to look at the whole history in the intermediate models.total_conversations_closedto conversations where there was a customer messagetotal_conversations_closed_allthat does not limit to conversations with customer messagesSubmission Checklist
Changelog