[fix] ensure consistent hook sorting by name#753
Merged
Conversation
Improve hook sorting by adding a secondary sort criterion based on hook names when orders are equal. This ensures consistent ordering of hooks with the same order value.
ipaqsa
approved these changes
Apr 24, 2026
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Improve hook sorting by adding a secondary sort criterion based on hook names when orders are equal. This ensures consistent ordering of hooks with the same order value.
What this PR does / why we need it
Hooks with the same Order value were executed in a non-deterministic order. This matters because an earlier hook can perform a check and set a value, allowing subsequent hooks to skip the check and simply read that value — but this pattern breaks when execution order is unpredictable.
The fix adds a secondary sort by hook name when Order values are equal, so hooks with the same priority are now always executed in alphabetical order.
Before:
After: