Improve host search by end user email address#40197
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #40197 +/- ##
==========================================
+ Coverage 66.28% 66.37% +0.08%
==========================================
Files 2459 2456 -3
Lines 196811 196765 -46
Branches 8714 8681 -33
==========================================
+ Hits 130451 130596 +145
+ Misses 54542 54345 -197
- Partials 11818 11824 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lucasmrod
approved these changes
Feb 23, 2026
Member
lucasmrod
left a comment
There was a problem hiding this comment.
LGTM!
Make sure to document that this needs to be load tested by QA.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: Resolves #15744
Checklist for submitter
changes/,orbit/changes/oree/fleetd-chrome/changes.See Changes files for more information.
Testing
Added/updated automated tests
Where appropriate, automated tests simulate multiple hosts and test for host isolation (updates to one hosts's records do not affect another)
QA'd all new/changed functionality manually
Manually inserted 10k hosts and random emails associated to them. Response times were always below 200ms locally.
We already have covering indexes so we don't need a migration.
Screen.Recording.2026-02-23.at.1.41.02.PM.mov
SQL used: