Propagate authenticated user when send-event task is sent asynchronously#4205
Open
kle-dev wants to merge 1 commit intoflowable:mainfrom
Open
Propagate authenticated user when send-event task is sent asynchronously#4205kle-dev wants to merge 1 commit intoflowable:mainfrom
kle-dev wants to merge 1 commit intoflowable:mainfrom
Conversation
The async send-event job re-evaluates eventInParameter source expressions
in a worker thread, where the Authentication thread-local is not set. As a
result expressions like ${authenticatedUserId} resolve to null even though
they would resolve correctly when the same task is configured with
flowable:sendSynchronously=true.
Capture the authenticated user when the async job is scheduled (storing it
on the JobEntity's jobHandlerConfiguration, which the handler does not
otherwise use) and restore it in AsyncSendEventJobHandler before invoking
the activity behavior. The previous authenticated user is restored in a
finally block.
kle-dev
force-pushed
the
fix/async-send-event-authenticated-user
branch
from
0cc9a18 to
45cbb64
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The async send-event job re-evaluates eventInParameter source expressions in a worker thread, where the Authentication thread-local is not set. As a result expressions like ${authenticatedUserId} resolve to null even though they would resolve correctly when the same task is configured with flowable:sendSynchronously=true.
Capture the authenticated user when the async job is scheduled (storing it on the JobEntity's jobHandlerConfiguration, which the handler does not otherwise use) and restore it in AsyncSendEventJobHandler before invoking the activity behavior. The previous authenticated user is restored in a finally block.
Check List: