docs: monitoring: fix hot_reloaded_times metric type#2383
docs: monitoring: fix hot_reloaded_times metric type#2383eschabell merged 2 commits intofluent:masterfrom
Conversation
- Change `fluentbit_hot_reloaded_times` type from `gauge` to `counter`
to reflect the source change in flb_metrics.c
Signed-off-by: Eric D. Schabell <eric@schabell.org>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: defaults Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughUpdated monitoring docs: added several new Prometheus metric entries, reorganized and reformatted v1/v2 metrics tables, and removed duplicate/older metric declarations; no public API or code changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related issues
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@administration/monitoring.md`:
- Line 211: The Unit value for the metric `fluentbit_hot_reloaded_times` is
incorrect — change the Unit column from `seconds` to a non-time unit such as
`times` or `count` in the table entry for `fluentbit_hot_reloaded_times`; keep
the name and label (`hostname`) and the type `counter` as-is to reflect that it
counts discrete hot-reload events rather than measuring duration.
Signed-off-by: Eric D. Schabell <eric@schabell.org>
fluentbit_hot_reloaded_timestype fromgaugetocounterto reflect the source change in flb_metrics.c from code fixing issue Metric fluentbit_hot_reloaded_times is currently a gauge impl, should be a counter impl fluent-bit#11479 with PR metrics: change hot_reloaded_times from gauge to counter fluent-bit#11489Summary by CodeRabbit