Skip to content

docs: monitoring: fix hot_reloaded_times metric type#2383

Merged
eschabell merged 2 commits intofluent:masterfrom
eschabell:erics_monitoring_metrics_update
Mar 5, 2026
Merged

docs: monitoring: fix hot_reloaded_times metric type#2383
eschabell merged 2 commits intofluent:masterfrom
eschabell:erics_monitoring_metrics_update

Conversation

@eschabell
Copy link
Collaborator

@eschabell eschabell commented Feb 23, 2026

Summary by CodeRabbit

  • Documentation
    • Expanded and reorganized monitoring metrics: added several Fluentbit metrics (retries, latency, uptime, start time, build info, hot-reload count) and consolidated entries.
    • Removed duplicate/older metric listings and adjusted formatting for clarity across metric versions.
    • Clarified metric presentation; aggregation semantics remain consistent.

  - Change `fluentbit_hot_reloaded_times` type from `gauge` to `counter`
    to reflect the source change in flb_metrics.c

Signed-off-by: Eric D. Schabell <eric@schabell.org>
@eschabell eschabell self-assigned this Feb 23, 2026
@eschabell eschabell added the 5.0 label Feb 23, 2026
@eschabell eschabell requested a review from a team as a code owner February 23, 2026 09:59
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 23, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e89acef and 2dd1b8a.

📒 Files selected for processing (1)
  • administration/monitoring.md
🚧 Files skipped from review as they are similar to previous changes (1)
  • administration/monitoring.md

📝 Walkthrough

Walkthrough

Updated monitoring docs: added several new Prometheus metric entries, reorganized and reformatted v1/v2 metrics tables, and removed duplicate/older metric declarations; no public API or code changes.

Changes

Cohort / File(s) Summary
Monitoring docs
administration/monitoring.md
Added new metrics (fluentbit_output_retries_failed_total, fluentbit_output_retries_total, fluentbit_output_latency_seconds, fluentbit_uptime, fluentbit_process_start_time_seconds, fluentbit_build_info, fluentbit_hot_reloaded_times), reordered/merged entries, removed previous duplicates/old declarations and adjusted formatting in v1/v2 metrics tables.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related issues

Possibly related PRs

Suggested labels

waiting-on-review

Suggested reviewers

  • cosmo0920
  • patrick-stephens

Poem

🐰 I hopped through metrics, tidy and bright,
Added counters, reordered by light,
Duplicates cleared with a nimble leap,
Docs now humbly count what they keep,
A rabbit's cheer for monitoring neat 🥕

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'docs: monitoring: fix hot_reloaded_times metric type' clearly and specifically describes the main change—updating the metric type documentation. It is concise, directly related to the primary change in the changeset, and provides meaningful information about what was modified.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@administration/monitoring.md`:
- Line 211: The Unit value for the metric `fluentbit_hot_reloaded_times` is
incorrect — change the Unit column from `seconds` to a non-time unit such as
`times` or `count` in the table entry for `fluentbit_hot_reloaded_times`; keep
the name and label (`hostname`) and the type `counter` as-is to reflect that it
counts discrete hot-reload events rather than measuring duration.

ℹ️ Review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4a18664 and e89acef.

📒 Files selected for processing (1)
  • administration/monitoring.md

Signed-off-by: Eric D. Schabell <eric@schabell.org>
@eschabell eschabell added the waiting-on-review Waiting on a review from mainteners label Feb 23, 2026
@eschabell eschabell merged commit dbc71a3 into fluent:master Mar 5, 2026
8 checks passed
@eschabell eschabell removed waiting-on-code-merge waiting-on-review Waiting on a review from mainteners labels Mar 6, 2026
@eschabell eschabell deleted the erics_monitoring_metrics_update branch March 6, 2026 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants