feat(in_exec): add command_timeout option to limit child process exec…#5320
Merged
kenhys merged 3 commits intofluent:masterfrom Apr 16, 2026
Merged
feat(in_exec): add command_timeout option to limit child process exec…#5320kenhys merged 3 commits intofluent:masterfrom
kenhys merged 3 commits intofluent:masterfrom
Conversation
…ution time Signed-off-by: zoklk <bjincheol34@gmail.com>
Signed-off-by: zoklk <bjincheol34@gmail.com>
Contributor
|
Hi @zoklk, thanks for this great PR! |
Contributor
Author
|
Hi @Watson1978 , I've sent a PR to the fluentd-docs-gitbook repository for the |
Contributor
|
@zoklk Thank you so much! |
Watson1978
previously approved these changes
Apr 10, 2026
Contributor
Watson1978
left a comment
There was a problem hiding this comment.
Looks good to me.
@kenhys Can you also review this PR?
kenhys
requested changes
Apr 13, 2026
Signed-off-by: zoklk <bjincheol34@gmail.com>
Contributor
|
waiting CI... |
kenhys
approved these changes
Apr 16, 2026
Contributor
|
@zoklk Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Fixes #5319
What this PR does / why we need it:
Adds
command_timeoutoption toin_execplugin, mirroring the existingcommand_timeoutoption inout_exec.Currently,
in_execcallschild_process_executewithoutwait_timeout,defaulting to
nil(infinite wait). When the external command hangs,Fluentd repeatedly shows
previous child process is still running. skipped.with no indication of the actual cause, making troubleshooting difficult.
out_execalready exposescommand_timeoutwhich maps towait_timeoutin
child_process_execute. This PR resolves the inconsistency betweenthe two plugins.
Docs Changes:
fluent/fluentd-docs-gitbook#619
Release Note:
Add
command_timeoutoption toin_execplugin to kill long-runningchild processes and align behavior with
out_exec.