Skip to content

[in_app_purchase_storekit] Address flaky tests #11270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LouiseHsu wants to merge 7 commits into
base: main
Choose a base branch
from
+18 −2
Open

[in_app_purchase_storekit] Address flaky tests #11270

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f4ac090
test flakes
LouiseHsu Mar 16, 2026
55600ae
clear session?
LouiseHsu Mar 16, 2026
8346421
nw error
LouiseHsu Mar 17, 2026
2a2d270
nw error
LouiseHsu Mar 17, 2026
d5b9a6a
format
LouiseHsu Mar 17, 2026
3dcdbb5
haha :(
LouiseHsu Mar 18, 2026
3d8929b
comments:
LouiseHsu Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions ..._app_purchase_storekit/example/shared/RunnerTests/InAppPurchaseStoreKit2PluginTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,13 @@ final class InAppPurchase2PluginTests: XCTestCase {
//TODO(louisehsu): Add testing for lower versions.
@available(iOS 17.0, macOS 14.0, *)
func testGetProductsWithStoreKitError() async throws {
let osVersion = ProcessInfo.processInfo.operatingSystemVersion
try XCTSkipIf(
// https://developer.apple.com/forums/thread/808030
osVersion.majorVersion == 26 && osVersion.minorVersion == 2,
"Known StoreKitTest bug on Xcode 26.2 with setSimulatedError() when used on .loadProducts API"
)
Comment on lines +184 to +189
Copy link
Contributor Author

@LouiseHsu LouiseHsu Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://developer.apple.com/forums/thread/808030
.setSimulatedError doesnt work on specifically 26.2, but apples availability annotation doesnt support donut hole versioning.

Copy link
Member

@jmagman jmagman Mar 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the URL into a comment somewhere? Definitely also in this PR description.


try await session.setSimulatedError(
.generic(.networkError(URLError(.badURL))), forAPI: .loadProducts)

Expand Down Expand Up @@ -217,6 +224,15 @@ final class InAppPurchase2PluginTests: XCTestCase {

@available(iOS 17.0, macOS 14.0, *)
func testFailedNetworkErrorPurchase() async throws {
let osVersion = ProcessInfo.processInfo.operatingSystemVersion
try XCTSkipIf(
// https://developer.apple.com/forums/thread/808030
osVersion.majorVersion == 26 && osVersion.minorVersion == 2,
"Known StoreKitTest bug on Xcode 26.2 with setSimulatedError() when used on .loadProducts API"
)

// StoreKitTest aggressively caches products and transaction, which means sometimes it bypasses a simulated error.
session.clearTransactions()
try await session.setSimulatedError(
.generic(.networkError(URLError(.badURL))), forAPI: .loadProducts)
let expectation = self.expectation(description: "products request should fail")
Expand Down Expand Up @@ -290,7 +306,7 @@ final class InAppPurchase2PluginTests: XCTestCase {
XCTFail("Purchase should NOT fail. Failed with \(error)")
}
}
await fulfillment(of: [expectation], timeout: 5)
await fulfillment(of: [expectation], timeout: 10)
}

func testDiscountedProductSuccess() async throws {
Expand All @@ -303,7 +319,7 @@ final class InAppPurchase2PluginTests: XCTestCase {
XCTFail("Purchase should NOT fail. Failed with \(error)")
}
}
await fulfillment(of: [expectation], timeout: 5)
await fulfillment(of: [expectation], timeout: 10)
}

func testPurchaseWithAppAccountToken() async throws {
Expand Down
Loading