Skip to content

[material_ui] Update Material tokens to version 38.0.15 - #12280

Open
elliette wants to merge 3 commits into
flutter:m3e_migrationfrom
elliette:material_tokens_v38.1.2_bdea2620
Open

[material_ui] Update Material tokens to version 38.0.15#12280
elliette wants to merge 3 commits into
flutter:m3e_migrationfrom
elliette:material_tokens_v38.1.2_bdea2620

Conversation

@elliette

@elliette elliette commented Jul 23, 2026

Copy link
Copy Markdown
Member

Contains changes introduced by the following CLs:

  • cl/944170221
  • cl/953009409
  • cl/952902672

As part of the changes:

  • The color files are now explicit in their brightness, i.e. color_light and color_dark instead of color and color_dark
  • If a color value for medium/high contrast matches the value for the default contrast, than we don't include it in the _contrast.dart file. We only include values that are different than the default.

Pre-Review Checklist

Text exemption: Generated code.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2

FolderOrigin-RevId: /google/src/cloud/elliottbrooks/typescale-tokens/google3/javascript/materialdesign/tokens/compiler/formats/flutter/staging_output
@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Jul 23, 2026
@github-actions github-actions Bot added triage-framework Should be looked at in framework triage p: material_ui labels Jul 23, 2026
@elliette
elliette requested a review from QuncCccccc July 23, 2026 23:39

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the generated default token data files to version 38.1.2. It replaces inline TypescaleStruct definitions with references to predefined TokenTypescale constants across multiple component files, renames TokenColor to TokenColorLight, and removes several color tokens from contrast-specific color files. Additionally, several banner and scrim token files have been deleted. As there are no review comments, no further feedback is provided.


class TokenColor {

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Part of this change includes explicitly including brightness for the color files, so the default (which was light) is now explicitly called color_light


class TokenColorLightHighContrast {
/// md.sys.color.background
static const String background = '0xFFFEF7FF';

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't include background here because it's identical to the TokenColorLight.background (ditto for the other removed values)

Comment thread packages/material_ui/tool/gen_defaults/data/data_table.dart Outdated
static const TokenColorRole labelTextColor = TokenColorRole.onSurface;

/// md.comp.assist-chip.label-text.type
static const TypescaleStruct labelTextType = TypescaleStruct(

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes on removing non-expressive components and colors look good to me! Should we wait until this reference issue is fixed in b/538295526? Or we can also land it for now and add //TODO when we use these tokens

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CICD Run CI/CD p: material_ui triage-framework Should be looked at in framework triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants