Fix callback name to match example code from 'onGuessSubmitted' to 'onSubmitGuess'#13009
Fix callback name to match example code from 'onGuessSubmitted' to 'onSubmitGuess'#13009sfshaza2 merged 3 commits intoflutter:mainfrom
Conversation
…nSubmitGuess' Fix callback name to match example code from 'onGuessSubmitted' to 'onSubmitGuess'. Every callback in the code examples uses 'onSubmitGuess', but currently the documentation refers to it as 'onGuessSubmitted' twice
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Summary of ChangesHello @PTMakes, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses an inconsistency in the documentation for a user input tutorial. It ensures that the callback function name mentioned in the text matches the 'onSubmitGuess' name used in the accompanying code examples, improving clarity and accuracy for learners. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request corrects the name of a callback function in the documentation, changing onGuessSubmitted to onSubmitGuess in two places within user-input.md. This change makes the documentation consistent with the code examples provided in the tutorial, which improves clarity and reduces potential confusion for developers following the guide. The changes are correct and well-contained.
|
/gcbrun |
|
Visit the preview URL for this PR (updated for commit 0290452): |
|
/gcbrun |
1 similar comment
|
/gcbrun |
|
/gcbrun |
4 participants
Description of what this PR is changing or adding, and why:
Fix callback name to match example code from 'onGuessSubmitted' to 'onSubmitGuess'
Every callback in the code examples uses 'onSubmitGuess', but currently the documentation refers to it as 'onGuessSubmitted' twice.
Issues fixed by this PR (if any):
N/A
PRs or commits this PR depends on (if any):
N/A
Presubmit checklist
If you are unwilling, or unable, to sign the CLA, even for a tiny, one-word PR, please file an issue instead of a PR.If this PR is not meant to land until a future stable release, mark it as draft with an explanation.This PR follows the Google Developer Documentation Style Guidelines—for example, it doesn't use i.e. or e.g., and it avoids I and we (first-person pronouns).This PR uses semantic line breaksof 80 characters or fewer.
(Edited to re-write this to match the provided template)