Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds documentation notes to the platform channels guide, explaining how to handle the UISceneDelegate lifecycle in both Swift and Objective-C to prevent crashes when the window is nil. The review feedback suggests minor wording adjustments for consistency and formatting changes to improve readability by wrapping long lines.
Collaborator
|
Visit the preview URL for this PR (updated for commit 8947780): https://flutter-docs-prod--pr13244-fix-13243-l500u0wo.web.app |
johnpryan
reviewed
Apr 1, 2026
| and set its call handler within your `SceneDelegate`'s | ||
| `scene:willConnectToSession:options:` method, | ||
| accessing the controller by using | ||
| `(FlutterViewController*)self.window.rootViewController`. |
Contributor
There was a problem hiding this comment.
I don't know if this is correct or not, I'll need to defer to @jmagman on this.
Member
There was a problem hiding this comment.
I think @LouiseHsu messaged @sfshaza2 with some code samples.
jmagman
requested review from
LouiseHsu and
vashworth
and removed request for
jmagman
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13243