Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the navigation tutorial documentation by adding a missing import to a Dart code snippet and including a note regarding a known Hero tag exception that occurs when resizing the application. A review comment suggests correcting the description of the page where this exception occurs from 'contact list page' to 'contact detail page' to accurately reflect the scenario where a route has been pushed to the Navigator.
|
Visit the preview URL for this PR (updated for commit 0bc91a5): https://flutter-docs-prod--pr13247-fix-13192-r0b8rhqr.web.app |
| `lib/screens/contact_groups.dart` is implemented as follows: | ||
|
|
||
| ```dart title="lib/screens/contact_groups.dart" | ||
| import 'package:rolodex/screens/contacts.dart'; |
There was a problem hiding this comment.
I don't think this is needed? Something doesn't seem right here, the rolodex package on pub.dev is not what we want (it's old and out of date), and the Rolodex project we were working on is no longer maintained.
3 participants
Fixes #13192
The user has identified a missing import and a crash that can happen in a specific situation. Fixing this crash in a more sophisticated way involves state management so, in this case, we've added a note.
FYI: @lamek