Skip to content

Add an "ide" component - #13708

Open
ericwindmill wants to merge 21 commits into
mainfrom
ide-component
Open

Add an "ide" component#13708
ericwindmill wants to merge 21 commits into
mainfrom
ide-component

Conversation

@ericwindmill

@ericwindmill ericwindmill commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Description of what this PR is changing or adding, and why:

This is adding an interactive IDE component, because its cool. I'm using it for the FlutterBench updates, but want to land this separately to keep the PR sane.

Also adds min/max width breakpoint scss mixin to site-shared. In a future PR, we should remove breakpoints file from sites/www, and also update all scss to use the breakpoints, but doing so here would add many files to this PR.

Screenshot 2026-08-15 at 11 53 41 AM Screenshot 2026-08-15 at 11 53 55 AM Screenshot 2026-08-15 at 11 54 18 AM

Comment thread packages/site_shared/lib/_sass/base/_breakpoints.scss
Comment thread sites/docs/src/data/flutter_bench_task_example.yml Outdated
@flutter-website-bot

flutter-website-bot commented Aug 11, 2026

Copy link
Copy Markdown
Collaborator

Staged preview of the updated flutter.dev site (updated for commit e7c3351):

https://flutter-dev-230821--www-pr13708-ide-component-djgv8rr8.web.app

@flutter-website-bot

flutter-website-bot commented Aug 11, 2026

Copy link
Copy Markdown
Collaborator

Staged preview of the updated docs.flutter.dev site (updated for commit e7c3351):

https://flutter-docs-prod--docs-pr13708-ide-component-1g9w9f0b.web.app

@ericwindmill
ericwindmill marked this pull request as ready for review August 15, 2026 18:51
@ericwindmill
ericwindmill requested review from a team and sfshaza2 as code owners August 15, 2026 18:51

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new interactive file-tree explorer component (IdeExplorer) for documentation sites, including its SASS styles, Jaspr Dart components, a custom markdown parser, and client-side interactivity scripts. The feedback highlights several critical issues: a potential hydration mismatch in SSR due to a global static counter, invalid HTML nesting of a inside a

element, a bug in the client-side folder expansion logic, and potential duplicate DOM ID generation in the markdown parser when files in different directories share the same name. Actionable refactoring suggestions and code blocks are provided to resolve these issues.

Comment thread sites/docs/lib/src/client/global_scripts.dart
Comment thread packages/site_shared/lib/components/common/ide_explorer/ide_explorer.dart Outdated
Comment thread packages/site_shared/lib/components/common/ide_explorer/markdown_component.dart Outdated
@ericwindmill ericwindmill changed the title [WIP] Add an "ide" component Add an "ide" component Aug 15, 2026
@parlough
parlough requested a review from schultek August 17, 2026 20:03
@parlough
parlough self-requested a review August 17, 2026 20:03
@ericwindmill ericwindmill mentioned this pull request Aug 18, 2026
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants