Repository navigation
fix(build): quote paths passed to dotnet test - #36
Merged
Merged
Conversation
`DotnetTest` concatenated the test project and the results directory into the raw argument string of `DotNet.exec`, which splits it like a command line, so in a checkout path with spaces each path became several arguments and `dotnet test` failed. Quote both paths with the `quoted` helper the documentation commands already use, moved out of `DocsTool` to share it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused change correctly addresses argument splitting while preserving existing behavior.
Review effort: Balanced
Findings: None
What changed in this PR
Fixes test execution when repository paths contain spaces.
Changes:
- Moves the shared
quotedhelper to module scope. - Quotes test project and results-directory paths passed to
dotnet test.
| File | Description |
|---|---|
build/build.fs |
Safely quotes filesystem paths in test command arguments. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
DotnetTestbuilt thedotnet testcommand by concatenating the test project path and theTestResultsdirectory into the raw argument string ofDotNet.exec, which splits it like a command line. In a checkout path with spaces each path became several arguments, sodotnet testcould not find the project and the test run failed. Both paths are now wrapped with the existingquotedhelper, which moves out ofDocsToolso the test target can share it. Copilot code review found the same issue in the copy of this build script in fsprojects/FSharp.Control.R3#21.Types of changes
What types of changes does your code introduce to FSharp.Azure.Cosmos?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Fantomascheck; the test suite was not run locally, while the identical change passedDotnetTestin a checkout path with spaces in chore: sync MCP servers, agent instructions, SDK and tooling withFSharp.Azure.CosmosFSharp.Control.R3#21🤖 Generated with Claude Code