fix(browse): respect GSTACK_CHROMIUM_PATH in headless mode#1035
Open
mvanhorn wants to merge 1 commit intogarrytan:mainfrom
Open
fix(browse): respect GSTACK_CHROMIUM_PATH in headless mode#1035mvanhorn wants to merge 1 commit intogarrytan:mainfrom
mvanhorn wants to merge 1 commit intogarrytan:mainfrom
Conversation
GSTACK_CHROMIUM_PATH was only read in launchHeaded() but not in launch(). Skills like /qa that use headless mode ignored the env var, breaking browse on NixOS and other non-FHS distros where the bundled chromium_headless_shell binary fails. Read the env var in launch() the same way launchHeaded() does and pass it as executablePath to chromium.launch(). Fixes garrytan#906
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GSTACK_CHROMIUM_PATHis only respected inlaunchHeaded()(browser-manager.ts:270) but not inlaunch()(browser-manager.ts:183). Skills like/qause headless mode by default, so settingGSTACK_CHROMIUM_PATHhas no effect when the bundledchromium_headless_shellfails on NixOS and other non-FHS distros.Changes
Read
GSTACK_CHROMIUM_PATHinlaunch()and pass it asexecutablePathtochromium.launch(), matching the existing pattern inlaunchHeaded().browse/src/browser-manager.ts: 3 lines added.Testing
bun testpasses (665 pass across skill validation and gen-skill-docs). The change mirrors the existing env var handling inlaunchHeaded()at line 270.Fixes #906
This contribution was developed with AI assistance (Claude Code).