fix: namespace generated Hermes skill names#1054
Open
dkoh12 wants to merge 1 commit intogarrytan:mainfrom
Open
fix: namespace generated Hermes skill names#1054dkoh12 wants to merge 1 commit intogarrytan:mainfrom
dkoh12 wants to merge 1 commit intogarrytan:mainfrom
Conversation
Co-authored-by: Hermes Agent (GitHub Copilot GPT-5.4) <agent@nousresearch.com>
b6e3439 to
abc734b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
Hermes deduplicates skills by frontmatter
name, not by directory name. Generated Hermes skills were written to namespaced directories likegstack-review/, but their frontmatter still used generic names likereview, causing Hermes to suppress them as duplicates of existing skills.Test Plan
hermes skills listshowsgstack-review,gstack-qa, andgstack-ship