[ENH] Refactor project_points_onto_surface for robustness and nonlinear projection support - #92
Draft
Leguark wants to merge 1 commit into
Draft
Conversation
…near projection support Refactors the `project_points_onto_surface` function to enable exact Newton-based projection for linear scalar fields and improve nonlinear field handling with residual re-evaluation requirements. Adds gradient and surface tolerance handling, error conditions for near-zero gradients, and improved validation for scalar and gradient inputs. Updates tests to validate projection correctness, idempotency, and edge cases. Enhances gradient field accessors in dense grid outputs to address inconsistencies.
Member
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jul 27, 2026
[FIX] Ensure tensors consistently move to backend device and add tests for GPU-specific behavior
#90
Draft
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors the
project_points_onto_surfacefunction to enable exact Newton-based projection for linear scalar fields and improve nonlinear field handling with residual re-evaluation requirements. Adds gradient and surface tolerance handling, error conditions for near-zero gradients, and improved validation for scalar and gradient inputs. Updates tests to validate projection correctness, idempotency, and edge cases. Enhances gradient field accessors in dense grid outputs to address inconsistencies.