blog: Qiskit IVR code validation#14
blog: Qiskit IVR code validation#14ajbozarth wants to merge 6 commits intogenerative-computing:mainfrom
Conversation
Signed-off-by: Alex Bozarth <[email protected]>
ajbozarth
requested review from
avinash2692 and
jakelorocco
and removed request for
a team
|
This depends on #13 to properly render the code blocks I also set the date to next Monday |
jakelorocco
left a comment
jakelorocco
left a comment
There was a problem hiding this comment.
Like the blog post! I think the intro is especially strong. I have a few grammatical nits but feel free to disagree / ignore, I think we just have different writing styles.
Signed-off-by: Alex Bozarth <[email protected]>
@jakelorocco Given this was AI generated then edited I'm not surprised if I missed grammar errors, I've made all your suggested changes |
|
Pending any further feedback I will merge this Monday midday (matching the date on the blog) |
- Clarify flake8-qiskit-migration covers 0.x-to-1.x and 1.x-to-2.x migrations - Tighten prose (remove LLM-ish framing constructions) - Remove imports from code snippet and inline req() to reduce visual noise Signed-off-by: Alex Bozarth <[email protected]>
|
@psschwei I've pushed an update addressing your review if you want to take a look and resolve the relevant comments |
vabarbosa
left a comment
vabarbosa
left a comment
There was a problem hiding this comment.
thank you @ajbozarth! i would also just ping @frankharkins for any possible feedback (if he wants) since he initially developed the flake8 qiskit plugin
Signed-off-by: Alex Bozarth <[email protected]>
@frankharkins if you want to contribute any input, I plan for this blog to go out around lunchtime EST Monday |
|
Would be nice to add link to docs, for example for a complete install instructions, etc. |
There is a link to the example in the blog on line 21, and the example does run without needing a local mellea (ie a user could just download the one file and run it without checking out mellea). What kind of links were you thinking and where? |
5 participants
Adds a new blog post: "Automatically Fixing Deprecated Qiskit Code with Instruct-Validate-Repair".