Conversation
Signed-off-by: Paul S. Schweigert <paul@paulschweigert.com>
4461d03 to
f0dc555
Compare
ajbozarth
left a comment
There was a problem hiding this comment.
The action looks ok to me, but I still have significant personal hesitation to having an action add a commit during the PR merge process. As I raised in scrum, it just rub me the wrong way process-wise
|
Also IIUC this would update a blog's date if we ever needed to go in later and make a minor edit |
|
I share @ajbozarth 's concern about source data mutation during the pipeline. A few other thoughts
Another thought - do validation rather than mutation, ie check the date is within X days of today. However this won't help where front matter/fixes are made, unless we also add an opt-out via some comment mechanism or PR tagging Overally if we don't add more sophistication around data persistence and distinction between data types I would prefer validation/rejection (despite then needing another edit) than mutation. So I would say I don't agree with the PR as it stands |
planetf1
left a comment
There was a problem hiding this comment.
disagree with proposal (but will re-review if solution changes)
|
The goal here was to avoid having to tweak a date by hand. I don't particularly care how it's done, but there is no good reason not have this automated somehow. |
No description provided.