ref(cli): Simplify add command flow#130
Merged
Merged
Conversation
Consolidate source acquisition, skill selection, and persistence while preserving existing add behavior. Cover validation ordering, interactive selection, source spelling, and single-install invariants. Co-Authored-By: Codex <noreply@openai.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consolidate the add command into source acquisition, skill selection, and persistence phases without changing its supported behavior.
The previous implementation repeated selection, duplicate handling, config writes, and installation across local, git, and well-known sources. Keeping those branches aligned made small changes risky and obscured invariants such as validating all requested skills before writing and installing only once.
This preserves source spelling, trust-before-network ordering, duplicate behavior, local root-skill handling, interactive cancellation, and existing error precedence. The added integration coverage exercises well-known parity and both successful interactive selection paths.
Garfield review and focused Docker QA covered local root, git multi-name, wildcard, and cached well-known add flows.