docs(python): update integrations for stream mode#18526
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
b09e983 to
8e5d8e1
Compare
alexander-alderman-webb
left a comment
There was a problem hiding this comment.
Thanks looks good! A few more occurrences of diverging names that I didn't call out
| # or sentry_sdk.traces.start_span(name="your_span_name", parent_span=None) in stream mode | ||
| with sentry_sdk.start_transaction(name="The result of the AI inference"): |
There was a problem hiding this comment.
Doesn't really matter but I think the names should be aligned here
| # or sentry_sdk.traces.start_span(name="your_span_name", parent_span=None) in stream mode | |
| with sentry_sdk.start_transaction(name="The result of the AI inference"): | |
| # or sentry_sdk.traces.start_span(name="The result of the AI inference", parent_span=None) in stream mode | |
| with sentry_sdk.start_transaction(name="The result of the AI inference"): |
| # or sentry_sdk.traces.start_span(name="your_span_name", parent_span=None) in stream mode | ||
| with sentry_sdk.start_transaction(name="testing_sentry"): |
There was a problem hiding this comment.
Doesn't really matter but I think the names should be aligned here
| # or sentry_sdk.traces.start_span(name="your_span_name", parent_span=None) in stream mode | |
| with sentry_sdk.start_transaction(name="testing_sentry"): | |
| # or sentry_sdk.traces.start_span(name="testing_sentry", parent_span=None) in stream mode | |
| with sentry_sdk.start_transaction(name="testing_sentry"): |
| # or sentry_sdk.traces.start_span(name="your_span_name", parent_span=None) in stream mode | ||
| with sentry_sdk.start_transaction(name="testing_sentry"): |
There was a problem hiding this comment.
Doesn't really matter but I think the names should be aligned here
| # or sentry_sdk.traces.start_span(name="your_span_name", parent_span=None) in stream mode | |
| with sentry_sdk.start_transaction(name="testing_sentry"): | |
| # or sentry_sdk.traces.start_span(name="testing_sentry", parent_span=None) in stream mode | |
| with sentry_sdk.start_transaction(name="testing_sentry"): |
| # or sentry_sdk.traces.start_span(name="your_span_name", parent_span=None) in stream mode | ||
| with sentry_sdk.start_transaction(name="testing_sentry"): |
There was a problem hiding this comment.
| # or sentry_sdk.traces.start_span(name="your_span_name", parent_span=None) in stream mode | |
| with sentry_sdk.start_transaction(name="testing_sentry"): | |
| # or sentry_sdk.traces.start_span(name="testing_sentry", parent_span=None) in stream mode | |
| with sentry_sdk.start_transaction(name="testing_sentry"): |
| with sentry_sdk.start_transaction(name="calling-a-celery-task"): | ||
| # or sentry_sdk.traces.start_span(name="your_span_name", parent_span=None) in stream mode |
There was a problem hiding this comment.
| with sentry_sdk.start_transaction(name="calling-a-celery-task"): | |
| # or sentry_sdk.traces.start_span(name="your_span_name", parent_span=None) in stream mode | |
| with sentry_sdk.start_transaction(name="calling-a-celery-task"): | |
| # or sentry_sdk.traces.start_span(name="calling-a-celery-task", parent_span=None) in stream mode |
| # or sentry_sdk.traces.start_span(name="your_span_name", parent_span=None) in stream mode | ||
| with sentry_sdk.start_transaction(name="The result of the AI inference"): |
There was a problem hiding this comment.
| # or sentry_sdk.traces.start_span(name="your_span_name", parent_span=None) in stream mode | |
| with sentry_sdk.start_transaction(name="The result of the AI inference"): | |
| # or sentry_sdk.traces.start_span(name="The result of the AI inference", parent_span=None) in stream mode | |
| with sentry_sdk.start_transaction(name="The result of the AI inference"): |
| # or sentry_sdk.traces.start_span(name="your_span_name", parent_span=None) in stream mode | ||
| with sentry_sdk.start_transaction(op="function", name="testing_sentry"): |
There was a problem hiding this comment.
| # or sentry_sdk.traces.start_span(name="your_span_name", parent_span=None) in stream mode | |
| with sentry_sdk.start_transaction(op="function", name="testing_sentry"): | |
| # or sentry_sdk.traces.start_span(name="testing_sentry", parent_span=None) in stream mode | |
| with sentry_sdk.start_transaction(op="function", name="testing_sentry"): |
| # or sentry_sdk.traces.start_span(name="your_span_name", parent_span=None) in stream mode | ||
| with sentry_sdk.start_transaction(name="testing_sentry"): |
There was a problem hiding this comment.
| # or sentry_sdk.traces.start_span(name="your_span_name", parent_span=None) in stream mode | |
| with sentry_sdk.start_transaction(name="testing_sentry"): | |
| # or sentry_sdk.traces.start_span(name="testing_sentry", parent_span=None) in stream mode | |
| with sentry_sdk.start_transaction(name="testing_sentry"): |
| # or sentry_sdk.traces.start_span(name="your_span_name", parent_span=None) in stream mode | ||
| with sentry_sdk.start_transaction(name="testing_sentry"): |
There was a problem hiding this comment.
| # or sentry_sdk.traces.start_span(name="your_span_name", parent_span=None) in stream mode | |
| with sentry_sdk.start_transaction(name="testing_sentry"): | |
| # or sentry_sdk.traces.start_span(name="testing_sentry", parent_span=None) in stream mode | |
| with sentry_sdk.start_transaction(name="testing_sentry"): |
| # or sentry_sdk.traces.start_span(name="your_span_name", parent_span=None) in stream mode | ||
| with sentry_sdk.start_transaction(name="testing_sentry"): |
There was a problem hiding this comment.
| # or sentry_sdk.traces.start_span(name="your_span_name", parent_span=None) in stream mode | |
| with sentry_sdk.start_transaction(name="testing_sentry"): | |
| # or sentry_sdk.traces.start_span(name="testing_sentry", parent_span=None) in stream mode | |
| with sentry_sdk.start_transaction(name="testing_sentry"): |
| def divide(a, b): | ||
| return a/b | ||
|
|
||
| # or sentry_sdk.traces.start_span(name="your_span_name", parent_span=None) in stream mode |
There was a problem hiding this comment.
Similar to the other naming consistency comments that Alex has left elsewhere
| # or sentry_sdk.traces.start_span(name="your_span_name", parent_span=None) in stream mode | |
| # or sentry_sdk.traces.start_span(name="ray-test", parent_span=None) in stream mode |
| sentry_sdk.init(...) # same as above | ||
| r = redis.Redis(host='localhost', port=6379, decode_responses=True) | ||
|
|
||
| # or sentry_sdk.traces.start_span(name="your_span_name", parent_span=None) in stream mode |
There was a problem hiding this comment.
| # or sentry_sdk.traces.start_span(name="your_span_name", parent_span=None) in stream mode | |
| # or sentry_sdk.traces.start_span(name="testing_sentry", parent_span=None) in stream mode |
| sentry_sdk.init(...) # same as above | ||
| rc = RedisCluster(host='localhost', port=16379) | ||
|
|
||
| # or sentry_sdk.traces.start_span(name="your_span_name", parent_span=None) in stream mode |
There was a problem hiding this comment.
| # or sentry_sdk.traces.start_span(name="your_span_name", parent_span=None) in stream mode | |
| # or sentry_sdk.traces.start_span(name="testing_sentry", parent_span=None) in stream mode |
| sentry_sdk.init(...) # same as above | ||
| r = redis.Redis(host='localhost', port=6379) | ||
|
|
||
| # or sentry_sdk.traces.start_span(name="your_span_name", parent_span=None) in stream mode |
There was a problem hiding this comment.
| # or sentry_sdk.traces.start_span(name="your_span_name", parent_span=None) in stream mode | |
| # or sentry_sdk.traces.start_span(name="testing_sentry", parent_span=None) in stream mode |
DESCRIBE YOUR PR
This PR contains the updated integration docs for stream mode.
what I did:
start_transactionis usedI decided to add callouts rather than make direct edits to each integration file.
I still need to update the integration files to match our new quick start guide format -> could update the stream mode docs then too
Important
Broken links: I added links to the New Spans guide on these pages, but since this guide does not exist in this branch, we get a linting error.
Should only be merged after #18456
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
LEGAL BOILERPLATE
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
EXTRA RESOURCES