fix(opentelemetry): [Data Collection 21] Exclude queries from span descriptions - #5985
Draft
adinauer wants to merge 6 commits into
Draft
Conversation
Parse the url.full fallback through the shared URL utility before using it as an HTTP span description. This removes query parameters and fragments while preserving route and target handling. Refs #5666 Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. This PR will not appear in the changelog. 🤖 This preview updates automatically when you update the PR. |
This was referenced Aug 25, 2026
📲 Install BuildsAndroid
|
Contributor
Performance metrics 🚀
|
…a-collection-opentelemetry-span-description
…a-collection-opentelemetry-span-description
Exclude query parameters and fragments when deriving Sentry span descriptions from the legacy http.target attribute. Leave the completed OpenTelemetry attribute unchanged. Refs #5666 Co-Authored-By: Claude <noreply@anthropic.com>
…a-collection-opentelemetry-span-description
…a-collection-opentelemetry-span-description
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Stack (Data Collection)
📜 Description
Exclude URL query parameters and fragments from OpenTelemetry HTTP span descriptions when the description falls back to
url.fullor legacyhttp.target.Parse those values through the shared
UrlUtilspath and use their URL-only representation for the derived Sentry description. Preserve the original completed OpenTelemetry attributes and the existing precedence ofhttp.route,http.target,url.full, andurl.path.💡 Motivation and Context
OpenTelemetry spans could use complete URL or request-target values as their descriptions, attaching sensitive query values and producing high-cardinality descriptions. Other Java HTTP integrations already use URL-only span descriptions.
This normalization only changes the derived Sentry description. Data Collection is not applied to completed OpenTelemetry attributes because the exporter cannot distinguish manually supplied attributes from values added by auto-instrumentation.
Refs #5666
💚 How did you test it?
./gradlew :sentry-opentelemetry:sentry-opentelemetry-core:test --tests '*OpenTelemetryAttributesExtractorTest' --tests '*SpanDescriptionExtractorTest'./gradlew spotlessApply apiDumpgit diff --check📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
Document that completed OpenTelemetry attributes are governed by OpenTelemetry configuration rather than Sentry Data Collection options.
#skip-changelog