Skip to content

chore(compose): Rename file for SentryTraced - #6059

Closed
0xadam-brown wants to merge 1 commit into
mainfrom
chore/new-file-for-sentry-traced
Closed

chore(compose): Rename file for SentryTraced#6059
0xadam-brown wants to merge 1 commit into
mainfrom
chore/new-file-for-sentry-traced

Conversation

@0xadam-brown

@0xadam-brown 0xadam-brown commented Sep 5, 2026

Copy link
Copy Markdown
Member

📜 Description

Renamed SentryComposeTracing.kt -> SentryTraced.kt to match our usual conventions + make it easier to find SentryTraced in the IDE.

Rename keeps binary compatibility with previous file name for Java clients.

💡 Motivation and Context

Having file names match public composable APIs is especially helpful b/c composables are functions, not classes, so most IDEs don't have a type-based global search for them (but do let you search files by name).

💚 How did you test it?

📝 Checklist

  • I added GH Issue ID & Linear ID
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.
  • Public API changes reviewed by another Mobile SDK team member or implemented according to the develop docs spec.

🔮 Next steps

#skip-changelog

@0xadam-brown 0xadam-brown added the sanity-check PR needs a lightweight review for obvious issues label Sep 7, 2026
@0xadam-brown
0xadam-brown force-pushed the fix/sentry-traced-origin-filtering-bug branch from 7b13e55 to fcdad89 Compare September 8, 2026 07:52
Base automatically changed from fix/sentry-traced-origin-filtering-bug to main September 8, 2026 10:12
Note: Rename keeps binary compatibility with previous file name for Java clients.
@0xadam-brown
0xadam-brown force-pushed the chore/new-file-for-sentry-traced branch from a79c3e7 to e8fbabc Compare September 8, 2026 10:14
@0xadam-brown

Copy link
Copy Markdown
Member Author

Rebased on an updated target; otherwise unchanged.

@0xadam-brown
0xadam-brown enabled auto-merge (squash) September 8, 2026 10:16
@0xadam-brown
0xadam-brown enabled auto-merge (squash) September 8, 2026 10:18
@0xadam-brown

Copy link
Copy Markdown
Member Author

Closing this PR, as my clanker tells me the issue mentioned here will continue indefinitely if this PR is merged, ie, we'll cause the SDK Size Path job to fail perpetually. (Fwiw, I also notice that no files in sentry-java use @file:JvmName.) We can try again if/when we update the R8 rules for the SDK Size Path job.

auto-merge was automatically disabled September 8, 2026 13:32

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

sanity-check PR needs a lightweight review for obvious issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants