ref(nestjs): Use @sentry/conventions#21492
Draft
mydea wants to merge 1 commit into
Draft
Conversation
mydea
requested review from
nicohrubec and
s1gr1d
and removed request for
a team
Source span/attribute keys from `@sentry/conventions` instead of the previous OpenTelemetry / vendored convention constants. No functional change. Depends on #21503 (relocates vendored deps out of `node_modules` in the build). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
mydea
force-pushed
the
feat/use-sentry-conventions-nestjs
branch
from
ee7f39d to
5ea2368
Compare
mydea
changed the base branch from
develop
to
feat/use-sentry-conventions-build-infra
mydea
force-pushed
the
feat/use-sentry-conventions-build-infra
branch
from
625467a to
2a83a9f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Switches
@sentry/nestjsto source span/attribute keys from@sentry/conventions. No functional change — the attribute values are identical.@sentry/conventionsis a build-time devDependency whose constants are vendored into the published bundles, so this adds no runtime dependency.Important
Depends on #21503 (build infra). That PR relocates vendored deps out of
node_modulesin the build output and must merge first — otherwise the vendored@sentry/conventionsis loaded as CommonJS at runtime (named imports fail) and breaks Vitest on Node 18.Part of splitting the larger
@sentry/conventionsmigration into per-package PRs.Ref: #20982