Skip to content

fix(typer): Guard against module shadowing #5253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alexander-alderman-webb wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(typer): Guard against module shadowing #5253

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion sentry_sdk/integrations/typer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@

try:
import typer
from typer.main import except_hook
except ImportError:
raise DidNotEnable("Typer not installed")

Expand All @@ -31,7 +32,7 @@ class TyperIntegration(Integration):

@staticmethod
def setup_once() -> None:
typer.main.except_hook = _make_excepthook(typer.main.except_hook) # type: ignore
typer.main.except_hook = _make_excepthook(except_hook) # type: ignore


def _make_excepthook(old_excepthook: "Excepthook") -> "Excepthook":
Expand Down
1 change: 0 additions & 1 deletion tests/test_shadowed_module.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ def pytest_generate_tests(metafunc):
"pure_eval",
"ray",
"trytond",
"typer",
},
)

Expand Down
Loading