feat(tracing): Gate SQL query params behind data collection options - #6976
Open
ericapisani wants to merge 1 commit into
Open
feat(tracing): Gate SQL query params behind data collection options#6976ericapisani wants to merge 1 commit into
ericapisani wants to merge 1 commit into
Conversation
Record SQL params and paramstyle in `record_sql_queries` based on the new `data_collection.database_query_data` option instead of the `_experiments.record_sql_params` flag. When data collection is enabled, it takes precedence over the legacy flag; otherwise the legacy behavior is preserved until the experiment is removed. Refs PY-2587
Contributor
Codecov Results 📊✅ 100505 passed | ⏭️ 7021 skipped | Total: 107526 | Pass Rate: 93.47% | Execution Time: 358m 37s 📊 Comparison with Base Branch
➖ Removed Tests (1)View removed tests
All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 2504 uncovered lines. Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 89.91% 89.92% +0.01%
==========================================
Files 193 193 —
Lines 24832 24840 +8
Branches 8912 8920 +8
==========================================
+ Hits 22326 22336 +10
- Misses 2506 2504 -2
- Partials 1417 1413 -4Generated by Codecov Action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Record SQL params and paramstyle in
record_sql_queriesbased on the newdata_collection.database_query_dataoption instead of the_experiments.record_sql_paramsflag. When data collection is enabled, it takes precedence over the legacy flag; otherwise the legacy behavior is preserved until the experiment is removed.Refs PY-2587