Repository navigation
feat(boto3): Add S3 extension - #7888
Merged
Merged
Conversation
Contributor
Codecov Results 📊✅ 55462 passed | ⏭️ 2755 skipped | Total: 58217 | Pass Rate: 95.27% | Execution Time: 152m 43s 📊 Comparison with Base Branch
All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 2061 uncovered lines. Coverage diff@@ Coverage Diff @@
## master #PR +/-##
==========================================
- Coverage 90.37% 90.06% -0.31%
==========================================
Files 202 187 -15
Lines 26552 20733 -5819
Branches 9854 7136 -2718
==========================================
+ Hits 23995 18672 -5323
- Misses 2557 2061 -496
- Partials 1495 1214 -281Generated by Codecov Action |
pabloDeputter
force-pushed
the
pablo/boto3-add-s3-extension
branch
from
October 6, 2026 14:53
08ce57f to
c43fff1
Compare
pabloDeputter
force-pushed
the
pablo/boto3-add-s3-extension
branch
from
October 7, 2026 12:47
ca494d2 to
9938a64
Compare
pabloDeputter
marked this pull request as ready for review
October 7, 2026 13:38
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 9eb12cd. Configure here.
ericapisani
approved these changes
Oct 7, 2026
ericapisani
left a comment
Member
There was a problem hiding this comment.
LGTM, just saw this one small (non-blocking) 🧹
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Adds the following request/response attributes:
aws.s3.bucket,aws.s3.key,aws.s3.upload_id,aws.s3.copy_source,aws.s3.delete,aws.s3.part_number,http.response.body.size(number of bytes in payload),file.size(represents the total file/object size)Following tests were removed/moved from old
test_s3.py(old boto3 integration only added s3 streaming responses support):test_basic()removed - basically only tests botocore xml parsing behavior; generic span behavior is already tested intest_client.py.test_streaming()/test_streaming_close()removed - behavior is already tested intest_client.pywith mock HTTP server.test_span_origin()removed - overlaps with existing tests.test_omit_url_data_if_parsing_fails()moved totest_client.pyand simplified since it's generic instrumentation.test_breadcrumb()andtest_url_query_data_collection_breadcrumb()moved and combined totest_client.py, once again since it's generic instrumentation.Issues
Resolves #7576