Skip to content

ref: Rename SEER constants to PIZZAAGENT#113141

Draft
JoshFerge wants to merge 1 commit intomasterfrom
jferg/ref/rename-seer-to-pizzaagent
Draft

ref: Rename SEER constants to PIZZAAGENT#113141
JoshFerge wants to merge 1 commit intomasterfrom
jferg/ref/rename-seer-to-pizzaagent

Conversation

@JoshFerge
Copy link
Copy Markdown
Member

@JoshFerge JoshFerge commented Apr 16, 2026

rename seer to pizza agent

Test plan

  • CI passes
  • Verify no runtime breakage from renamed identifiers

Agent transcript: https://claudescope.sentry.dev/share/GYRRDtnTxV_5yGy05PuVuB-eTle4FBKmO75AC-B_02E

Rename ~28 SEER-prefixed variable names, constants, and enum members
to PIZZAAGENT across 14 source files. String values are preserved
to avoid breaking metrics, APIs, or wire protocols.

Agent transcript: https://claudescope.sentry.dev/share/8KJyIv_iG4aB_hcqOWL1c3jxsgmxUKPSX_RneXpKPeE
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 16, 2026
@JoshFerge
Copy link
Copy Markdown
Member Author

@sentry review

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 16, 2026

Backend Test Failures

Failures on 4a40fb7 in this run:

tests/sentry/integrations/slack/test_message_builder.py::BuildGroupAttachmentTest::test_autofix_button_hidden_on_unfurllog
[gw0] linux -- Python 3.13.1 /home/runner/work/sentry/sentry/.venv/bin/python3
tests/sentry/integrations/slack/test_message_builder.py:1153: in test_autofix_button_hidden_on_unfurl
    assert not self._has_autofix_button(blocks)
tests/sentry/integrations/slack/test_message_builder.py:1095: in _has_autofix_button
    if SlackAction.SEER_AUTOFIX_START.value in action_id:
E   AttributeError: type object 'SlackAction' has no attribute 'SEER_AUTOFIX_START'
tests/sentry/integrations/slack/test_message_builder.py::BuildGroupAttachmentTest::test_autofix_button_hidden_without_enhanced_alerts_optionlog
[gw0] linux -- Python 3.13.1 /home/runner/work/sentry/sentry/.venv/bin/python3
tests/sentry/integrations/slack/test_message_builder.py:1140: in test_autofix_button_hidden_without_enhanced_alerts_option
    assert not self._has_autofix_button(blocks)
tests/sentry/integrations/slack/test_message_builder.py:1095: in _has_autofix_button
    if SlackAction.SEER_AUTOFIX_START.value in action_id:
E   AttributeError: type object 'SlackAction' has no attribute 'SEER_AUTOFIX_START'
tests/sentry/integrations/slack/test_message_builder.py::BuildGroupAttachmentTest::test_autofix_button_shown_when_all_conditions_metlog
[gw0] linux -- Python 3.13.1 /home/runner/work/sentry/sentry/.venv/bin/python3
tests/sentry/integrations/slack/test_message_builder.py:1110: in test_autofix_button_shown_when_all_conditions_met
    assert self._has_autofix_button(blocks)
tests/sentry/integrations/slack/test_message_builder.py:1095: in _has_autofix_button
    if SlackAction.SEER_AUTOFIX_START.value in action_id:
E   AttributeError: type object 'SlackAction' has no attribute 'SEER_AUTOFIX_START'
tests/sentry/integrations/slack/test_message_builder.py::BuildGroupAttachmentTest::test_autofix_button_hidden_without_slack_workflows_flaglog
[gw1] linux -- Python 3.13.1 /home/runner/work/sentry/sentry/.venv/bin/python3
tests/sentry/integrations/slack/test_message_builder.py:1125: in test_autofix_button_hidden_without_slack_workflows_flag
    assert not self._has_autofix_button(blocks)
tests/sentry/integrations/slack/test_message_builder.py:1095: in _has_autofix_button
    if SlackAction.SEER_AUTOFIX_START.value in action_id:
E   AttributeError: type object 'SlackAction' has no attribute 'SEER_AUTOFIX_START'
tests/sentry/seer/endpoints/test_seer_rpc.py::TestSeerRpcMethods::test_send_seer_webhook_operatorlog
[gw0] linux -- Python 3.13.1 /home/runner/work/sentry/sentry/.venv/bin/python3
tests/sentry/seer/endpoints/test_seer_rpc.py:530: in test_send_seer_webhook_operator
    "event_type": SentryAppEventType.SEER_ROOT_CAUSE_COMPLETED,
E   AttributeError: type object 'SentryAppEventType' has no attribute 'SEER_ROOT_CAUSE_COMPLETED'. Did you mean: 'PIZZAAGENT_ROOT_CAUSE_COMPLETED'?

@JoshFerge
Copy link
Copy Markdown
Member Author

@sentry review

1 similar comment
@JoshFerge
Copy link
Copy Markdown
Member Author

@sentry review

Comment on lines +148 to 158
PIZZAAGENT_SOLUTION_COMPLETED = "seer.solution_completed"
PIZZAAGENT_CODING_STARTED = "seer.coding_started"
PIZZAAGENT_CODING_COMPLETED = "seer.coding_completed"
PIZZAAGENT_TRIAGE_STARTED = "seer.triage_started"
PIZZAAGENT_TRIAGE_COMPLETED = "seer.triage_completed"
PIZZAAGENT_IMPACT_ASSESSMENT_STARTED = "seer.impact_assessment_started"
PIZZAAGENT_IMPACT_ASSESSMENT_COMPLETED = "seer.impact_assessment_completed"
PIZZAAGENT_PR_CREATED = "seer.pr_created"

# preprod artifact webhooks
PREPROD_ARTIFACT_SIZE_ANALYSIS_COMPLETED = "preprod_artifact.size_analysis_completed"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The renaming of SentryAppEventType enum members is incomplete. References to the old SEER_* names in test and fixture files will cause an AttributeError during test execution.
Severity: HIGH

Suggested Fix

Update all references to the old SentryAppEventType enum members (e.g., SentryAppEventType.SEER_ROOT_CAUSE_COMPLETED) to use their new PIZZAAGENT_* names in all affected files, including fixtures/seer/webhooks.py and various test files.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.

Location: src/sentry/sentry_apps/metrics.py#L141-L158

Potential issue: The PR renames several `SentryAppEventType` enum members from `SEER_*`
to `PIZZAAGENT_*`, but fails to update all references to these old names. Specifically,
`fixtures/seer/webhooks.py` uses the old enum members as keys in a module-level
dictionary. When this module is imported by tests, it will immediately try to access the
non-existent enum members, raising an `AttributeError` and causing CI test runs to fail.
Other test files like `tests/sentry/seer/endpoints/test_seer_rpc.py` and
`tests/sentry/seer/entrypoints/test_operator.py` also contain references to the old
names, which will lead to similar failures.

Also affects:

  • fixtures/seer/webhooks.py
  • tests/sentry/seer/endpoints/test_seer_rpc.py
  • tests/sentry/seer/entrypoints/test_operator.py

Did we get this right? 👍 / 👎 to inform future reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant