ref: Rename SEER constants to PIZZAAGENT#113141
Draft
Conversation
Rename ~28 SEER-prefixed variable names, constants, and enum members to PIZZAAGENT across 14 source files. String values are preserved to avoid breaking metrics, APIs, or wire protocols. Agent transcript: https://claudescope.sentry.dev/share/8KJyIv_iG4aB_hcqOWL1c3jxsgmxUKPSX_RneXpKPeE
Member
Author
|
@sentry review |
Contributor
Backend Test FailuresFailures on
|
Member
Author
|
@sentry review |
1 similar comment
Member
Author
|
@sentry review |
Comment on lines
+148
to
158
| PIZZAAGENT_SOLUTION_COMPLETED = "seer.solution_completed" | ||
| PIZZAAGENT_CODING_STARTED = "seer.coding_started" | ||
| PIZZAAGENT_CODING_COMPLETED = "seer.coding_completed" | ||
| PIZZAAGENT_TRIAGE_STARTED = "seer.triage_started" | ||
| PIZZAAGENT_TRIAGE_COMPLETED = "seer.triage_completed" | ||
| PIZZAAGENT_IMPACT_ASSESSMENT_STARTED = "seer.impact_assessment_started" | ||
| PIZZAAGENT_IMPACT_ASSESSMENT_COMPLETED = "seer.impact_assessment_completed" | ||
| PIZZAAGENT_PR_CREATED = "seer.pr_created" | ||
|
|
||
| # preprod artifact webhooks | ||
| PREPROD_ARTIFACT_SIZE_ANALYSIS_COMPLETED = "preprod_artifact.size_analysis_completed" |
Contributor
There was a problem hiding this comment.
Bug: The renaming of SentryAppEventType enum members is incomplete. References to the old SEER_* names in test and fixture files will cause an AttributeError during test execution.
Severity: HIGH
Suggested Fix
Update all references to the old SentryAppEventType enum members (e.g., SentryAppEventType.SEER_ROOT_CAUSE_COMPLETED) to use their new PIZZAAGENT_* names in all affected files, including fixtures/seer/webhooks.py and various test files.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: src/sentry/sentry_apps/metrics.py#L141-L158
Potential issue: The PR renames several `SentryAppEventType` enum members from `SEER_*`
to `PIZZAAGENT_*`, but fails to update all references to these old names. Specifically,
`fixtures/seer/webhooks.py` uses the old enum members as keys in a module-level
dictionary. When this module is imported by tests, it will immediately try to access the
non-existent enum members, raising an `AttributeError` and causing CI test runs to fail.
Other test files like `tests/sentry/seer/endpoints/test_seer_rpc.py` and
`tests/sentry/seer/entrypoints/test_operator.py` also contain references to the old
names, which will lead to similar failures.
Also affects:
fixtures/seer/webhooks.pytests/sentry/seer/endpoints/test_seer_rpc.pytests/sentry/seer/entrypoints/test_operator.py
Did we get this right? 👍 / 👎 to inform future reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rename seer to pizza agent
Test plan
Agent transcript: https://claudescope.sentry.dev/share/GYRRDtnTxV_5yGy05PuVuB-eTle4FBKmO75AC-B_02E