fix(tracemetrics): Metric panel title should use equation with label#113143
Draft
narsaynorath wants to merge 2 commits intonar/fix/tracemetrics-resync-all-metric-queries-on-changefrom
Draft
Conversation
github-actions
bot
added
the
Scope: Frontend
…e' into nar/fix/tracemetrics-equation-chart-labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Primarily, the equation builder was supposed to avoid leaking the internal representation out of itself, but because we want to display it in another component (i.e. the chart title), we need to expose a way to hook into the internal value when a change is reported.
In this case, call the
handleExpressionChangecallback with both the resolved version, and the internal version so we can read it and store it in local state for the metric panel to use for the title. This only applies to equations right now but I've made the terminology more general (i.e.title, etc)Ideally,
useMetricLabelwould have been able to provide this but I didn't really want to store more metadata higher than the metric panel, where it's relevant