fix(explore): Reduce time window in trace item details#118566
Open
k-fish wants to merge 1 commit into
Open
Conversation
Adds an option for the trace item details endpoint time buffer. Item details are used for a particular item which happens in a fixed point in time (unlike a trace, which doesn't strictly have a start and end), so we don't need a large time window. We can potentially make this way lower, but this should speed it up significantly for now. Original source for this bug was that +/- 3 day was causing timeouts on large orgs. Fixes LOGS-897
github-actions
Bot
added
the
Scope: Backend
| assert trace_details_response.status_code == 404, trace_details_response.content | ||
|
|
||
| @override_options({"performance.traces.trace-item-details-timebuffer-minutes": 1.0}) | ||
| def test_timestamp_respects_timebuffer_option(self) -> None: |
Contributor
There was a problem hiding this comment.
Could we add a test that tests going through the default option of 5 mins?
adrianviquez
approved these changes
Jun 26, 2026
adrianviquez
left a comment
adrianviquez
left a comment
Contributor
There was a problem hiding this comment.
Small test suggestion but otherwise lgtm 🚀
nsdeschenes
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an option for the trace item details endpoint time buffer. Item details are used for a particular item which happens in a fixed point in time (unlike a trace, which doesn't strictly have a start and end), so we don't need a large time window. We can potentially make this way lower, but this should speed it up significantly for now.
Original source for this bug was that +/- 3 day was causing timeouts on large orgs.
Fixes LOGS-897