chore(notif-platform): Allow headers + footers to support rich text#118573
Draft
leeandher wants to merge 7 commits into
Draft
chore(notif-platform): Allow headers + footers to support rich text#118573leeandher wants to merge 7 commits into
leeandher wants to merge 7 commits into
Conversation
github-actions
Bot
added
Scope: Frontend
Contributor
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
Christinarlong
approved these changes
Jun 26, 2026
Christinarlong
left a comment
Christinarlong
left a comment
Contributor
There was a problem hiding this comment.
oof that's annoying , I wonder if we can ask claude to do a pass over to change all the current footers to be in the block formatting instead of having to handle both cases
![sentry-warden[bot]](https://avatars.githubusercontent.com/in/2755838?s=60&v=4){kind=small}
leeandher
force-pushed
the
leanderrodrigues/iswf-2917-replace-button-for-issue-alert-with-footer-link
branch
from
5ee44ae to
b5b153e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The type has been changed from
strtostr | list[FormattingBlock], and added pathways for parsing and interpreting both. It seemed to work fine for all providers except I couldn't test MS Teams.The only caveat is email subjects which obviously can't support rich text.
This approach is kinda ugly but would avoid custom renderers for small adjustments.