Skip to content

ci(selective): force Seer public API matrix on publish_status edits - #122950

Draft
sentry-junior[bot] wants to merge 3 commits into
masterfrom
junior/selective-publish-status-matrix
Draft

ci(selective): force Seer public API matrix on publish_status edits#122950
sentry-junior[bot] wants to merge 3 commits into
masterfrom
junior/selective-publish-status-matrix

Conversation

@sentry-junior

@sentry-junior sentry-junior Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Summary

When a PR only flips publish_status to PUBLIC (no handler rewrite), selective testing often never imports tests/sentry/seer/endpoints/test_organization_agent_token.py. Master still runs the full Seer public-mutation matrix, which auto-discovers every PUBLIC mutation and fails if the endpoint 404s behind a feature/plan gate.

That gap greened the issue-views publish PRs and then broke Backend on master (and blocked s4s2 checks).

Change

If any changed non-test .py file declares publish_status, always include:
tests/sentry/seer/endpoints/test_organization_agent_token.py

Test plan

  • test_compute_sentry_selected_tests.py (62 passed)
  • CI on this PR

Context

  • Incident: s4s2 deploy checks + master Backend red on agent-token matrix for OrganizationGroupSearchViewsEndpoint POST
  • Related: publish revert already landed; matrix behavior for flag-gated PUBLIC endpoints may still get a separate fix

Requested by dan.

--

View Junior Session [Sentry]

Selective testing only follows coverage and static imports, so flipping an
endpoint to ApiPublishStatus.PUBLIC can land green on PRs while master fails
the Seer agent-token public-mutation matrix. Detect publish_status in changed
source files and always include that matrix test.

Co-Authored-By: Dan Fuller <dfuller@sentry.io>
@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Aug 27, 2026
sentry-junior Bot and others added 2 commits August 27, 2026 23:03
Co-Authored-By: Dan Fuller <dfuller@sentry.io>
Replace content scanning for publish_status with a path trigger on
src/sentry/**/endpoints/**.py so selection stays path-based like the
rest of this script.

Co-Authored-By: Dan Fuller <dfuller@sentry.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant