feat(eslint): make no-redudant-default-arguments work across files - #122976
Merged
TkDodo merged 2 commits intoAug 28, 2026
Merged
Conversation
github-actions
Bot
added
the
Scope: Frontend
3 tasks
Collaborator
Author
|
bugbot run |
Contributor
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit bfe3dfe. Configure here.
TkDodo
marked this pull request as ready for review
August 28, 2026 09:56
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
TkDodo
deleted the
tkdodo/feat/eslint-no-redudant-default-arguments-accross-files
branch
August 28, 2026 11:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The initial rule worked without type information, which means it couldn’t track across files. That made it somewhat usable, but the biggest offenders are usually cross-file imports.
The rule is now updated and found 150+ more usages where we pass the defaultValue unnecessarily to a function or component.