Fix in the example in examples/retrieval #18400
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick fix in the retrieval example so that only at most n_seq_max chunks of
text are added to the llama_batch and this example stop crashing due attempting
to process more token sequences in a batch than allocated by llama_context::
encode and llama_context::decode.
The retrieval example crashes because (according to my understanding of the llama_context code) llama_context::encode is going to allocate n_seq_max sequences of tokens, and the loop in the example keeps adding more sequences. I added a condition so that the loop stops adding tokens when s reaches llama_n_seq_max(ctx).