Skip to content

cmake: use writev(3p) wrapper as needed#2078

Closed
dscho wants to merge 1 commit intogitgitgadget:masterfrom
dscho:writev-vs-cmake
Closed

cmake: use writev(3p) wrapper as needed#2078
dscho wants to merge 1 commit intogitgitgadget:masterfrom
dscho:writev-vs-cmake

Conversation

@dscho
Copy link
Copy Markdown
Member

@dscho dscho commented Apr 3, 2026

This was necessary to get Git for Windows v2.54.0-rc0's CI builds to pass successfully.

This is a companion patch of 3b9b2c2 (compat/posix: introduce
writev(3p) wrapper, 2026-03-13) where support for using the `writev()`
wrapper was introduced in the `Makefile` and the Meson-based build, but
the CMake build still needs that treatment, too.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
@dscho dscho self-assigned this Apr 3, 2026
@dscho
Copy link
Copy Markdown
Member Author

dscho commented Apr 3, 2026

/submit

@gitgitgadget
Copy link
Copy Markdown

gitgitgadget bot commented Apr 3, 2026

Submitted as pull.2078.git.1775206502134.gitgitgadget@gmail.com

To fetch this version into FETCH_HEAD:

git fetch https://github.com/gitgitgadget/git/ pr-2078/dscho/writev-vs-cmake-v1

To fetch this version to local tag pr-2078/dscho/writev-vs-cmake-v1:

git fetch --no-tags https://github.com/gitgitgadget/git/ tag pr-2078/dscho/writev-vs-cmake-v1

@gitgitgadget
Copy link
Copy Markdown

gitgitgadget bot commented Apr 3, 2026

This patch series was integrated into seen via git@0de485a.

@gitgitgadget
Copy link
Copy Markdown

gitgitgadget bot commented Apr 3, 2026

This patch series was integrated into next via git@c0dfe4a.

@gitgitgadget
Copy link
Copy Markdown

gitgitgadget bot commented Apr 4, 2026

This branch is now known as js/cmake-needs-writev-compat-too.

@gitgitgadget
Copy link
Copy Markdown

gitgitgadget bot commented Apr 4, 2026

This patch series was integrated into seen via git@ac340a6.

@gitgitgadget
Copy link
Copy Markdown

gitgitgadget bot commented Apr 4, 2026

This patch series was integrated into master via git@ac340a6.

@gitgitgadget
Copy link
Copy Markdown

gitgitgadget bot commented Apr 4, 2026

This patch series was integrated into next via git@ac340a6.

@gitgitgadget gitgitgadget bot added the master label Apr 4, 2026
@gitgitgadget gitgitgadget bot closed this Apr 4, 2026
@gitgitgadget
Copy link
Copy Markdown

gitgitgadget bot commented Apr 4, 2026

Congratulations! 🎉 Your patch series was merged into upstream via ac340a6.

Note: this pull request will show as "Closed" rather than "Merged" because the merge happened in the upstream repository, not on GitHub. This is expected — your contribution has been accepted!

@dscho dscho deleted the writev-vs-cmake branch April 4, 2026 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant